Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
nodegit just published its new version 0.18.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of nodegit.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
API Changes
waitForResult
flag that can betrue
/false
. Defaults to false. When true it will not stop libgit2 from continuing on before the JS code is fully executed and resolved (in cases of a Promise). This is useful for progress callbacks (like fetching) where the bubbling up of the progress to JS doesn't really need the C/C++ code to wait for the JS code to fully handle the event before continuing. This can have serious performance implications for many callbacks that can be fired quite frequently.given_opts
inRevert.revert
are now optionalcheckout_opts
inReset.fromAnnotated
andReset.reset
are now optionalReset.fromAnnotated
is now asyncmessage
onStash.save
is now optionalprocessMergeMessageCallback
onRepository#mergeBranches
to allow for custom merge messagesbeforeFinishFn
toRepository#rebaseBranches
andRepository#continueRebase
. This is called before the invocation offinish()
. If the callback returns a promise,finish()
will be called when the promise resolves. ThebeforeFinishFn
will be called with an object that has on it:ontoName
The name of the branch that we rebased ontoontoSha
The sha that we rebased ontooriginalHeadName
The name of the branch that we rebasedoriginalHeadSha
The sha of the branch that was rebasedrewitten
which is an array of sha pairs that contain which contain what the commit sha was before the rebase and what the commit sha is after the rebaseSummary of Changes from bumping libgit2 to 43275f5
PR #1123 bumped libgit2 which brought in many changes and bug fixes.
Included merged libgit2 PRs:
Included non-merged libgit2 PRs:
Summary of Changes to NodeGit outside of libgit2 bump
given_opts
inRevert.revert
optional PR #1213Reset.fromAnnotated
async andcheckout_opts
optional PR #1214message
onStash.save
optional PR #1215Remote.ls
to NodeGit PR #1218processMergeMessageCallback
toRepository#mergeBranches
to allow for custom merge messages PR #1219sudo
requirement from linux 32-bit builds PR #1241The new version differs by 139 commits .
6ff12ed
Remove
options
being optional onStash.apply
andStash.pop
ad991fd
Bump to 0.18.0
5fd0ace
Merge pull request #1224 from implausible/feature/provide-rebase-details-on-finish
07da8b4
Merge pull request #1232 from srajko/throttle-overflow-fix
d329e2b
Merge pull request #1208 from srajko/callback-fire-forget
4141760
Should test everything, not just rebase
bace8b7
Merge pull request #1238 from saper/remove-nwjs-doc
0ce02af
Merge pull request #1236 from saper/generatedpath
1df186d
Merge pull request #1234 from rcjsuen/commit-tests
c018da1
Use wider int to calculate throttle window
e66d20c
Merge pull request #1209 from rcjsuen/errno
6b1f73b
Merge pull request #1223 from srajko/bump-libgit
450a337
Merge pull request #1241 from nodegit/fix-linux-32
d7e8b9e
Add tests back in for 32-bit systems
e3fd303
Remove
sudo: required
from 32-bit linux buildsThere are 139 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.