Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodegit to version 0.18.0 🚀 #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

nodegit just published its new version 0.18.0.

State Update 🚀
Dependency nodegit
New version 0.18.0
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of nodegit.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

API Changes

  • All callbacks that go to libgit2 now have an optional waitForResult flag that can be true/false. Defaults to false. When true it will not stop libgit2 from continuing on before the JS code is fully executed and resolved (in cases of a Promise). This is useful for progress callbacks (like fetching) where the bubbling up of the progress to JS doesn't really need the C/C++ code to wait for the JS code to fully handle the event before continuing. This can have serious performance implications for many callbacks that can be fired quite frequently.
  • given_opts in Revert.revert are now optional
  • checkout_opts in Reset.fromAnnotated and Reset.reset are now optional
  • Reset.fromAnnotated is now async
  • message on Stash.save is now optional
  • Added processMergeMessageCallback on Repository#mergeBranches to allow for custom merge messages
  • Add beforeFinishFn to Repository#rebaseBranches and Repository#continueRebase. This is called before the invocation of finish(). If the callback returns a promise, finish() will be called when the promise resolves. The beforeFinishFn will be called with an object that has on it:
    • ontoName The name of the branch that we rebased onto
    • ontoSha The sha that we rebased onto
    • originalHeadName The name of the branch that we rebased
    • originalHeadSha The sha of the branch that was rebased
    • rewitten which is an array of sha pairs that contain which contain what the commit sha was before the rebase and what the commit sha is after the rebase

Summary of Changes from bumping libgit2 to 43275f5

PR #1123 bumped libgit2 which brought in many changes and bug fixes.

Included merged libgit2 PRs:

Included non-merged libgit2 PRs:

Summary of Changes to NodeGit outside of libgit2 bump

  • Don't overwrite C++ files for things that haven't changed PR #1091
  • Add the option to "fire and forget" callbacks so libgit2 doesn't wait for JS to finish before proceeding PR #1208
  • Send back the error code from libgit2 when a call fails PR #1209
  • Initialize pointers to null PR #1210
  • Replace Gitter with Slack PR #1212
  • Make given_opts in Revert.revert optional PR #1213
  • Make Reset.fromAnnotated async and checkout_opts optional PR #1214
  • Make message on Stash.save optional PR #1215
  • Add Remote.ls to NodeGit PR #1218
  • Add processMergeMessageCallback to Repository#mergeBranches to allow for custom merge messages PR #1219
  • Bump libgit2 to 43275f5 PR #1223 from srajko/bump-libgit
  • Provide rebase details on finish PR #1224
  • Use wider int to calculate throttle window PR #1232
  • Update comment to reflect the correct path for generated code output PR #1236
  • Remove nwjs example from the docs PR #1238
  • Remove sudo requirement from linux 32-bit builds PR #1241

The new version differs by 139 commits .

  • 6ff12ed Remove options being optional on Stash.apply and Stash.pop
  • ad991fd Bump to 0.18.0
  • 5fd0ace Merge pull request #1224 from implausible/feature/provide-rebase-details-on-finish
  • 07da8b4 Merge pull request #1232 from srajko/throttle-overflow-fix
  • d329e2b Merge pull request #1208 from srajko/callback-fire-forget
  • 4141760 Should test everything, not just rebase
  • bace8b7 Merge pull request #1238 from saper/remove-nwjs-doc
  • 0ce02af Merge pull request #1236 from saper/generatedpath
  • 1df186d Merge pull request #1234 from rcjsuen/commit-tests
  • c018da1 Use wider int to calculate throttle window
  • e66d20c Merge pull request #1209 from rcjsuen/errno
  • 6b1f73b Merge pull request #1223 from srajko/bump-libgit
  • 450a337 Merge pull request #1241 from nodegit/fix-linux-32
  • d7e8b9e Add tests back in for 32-bit systems
  • e3fd303 Remove sudo: required from 32-bit linux builds

There are 139 commits in total. See the full diff.


✨ Try the all new Greenkeeper GitHub Integration
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.

Screencast

Try it today. Free for private repositories during beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants