Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https://github.com/xeptore/flaw package #5153

Closed
wants to merge 1 commit into from
Closed

Add https://github.com/xeptore/flaw package #5153

wants to merge 1 commit into from

Conversation

xeptore
Copy link

@xeptore xeptore commented Dec 25, 2023

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.
  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Thanks for your PR, you're awesome! 👍

Copy link

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • godoc.org or pkg.go.dev
  • goreportcard.com
  • coverage

your project is about to be approved, it's under revision, it may take a few days

@cassiobotaro
Copy link
Collaborator

@xeptore Why is this PR still on draft? Do you need some help?

@xeptore
Copy link
Author

xeptore commented Jan 27, 2024

Looking for spare time to update the repo, and mark remaining check boxes, @cassiobotaro.

@phanirithvij
Copy link
Collaborator

Forgive me for being blunt but how come you're already at v8 when no one is using your library.

@xeptore
Copy link
Author

xeptore commented Mar 9, 2024

Forgive me for being blunt but how come you're already at v8 when no one is using your library.

* no one publicly maybe?

Also, where can I find out users of a specific package beside the "imported by" section in pkg.go.dev, @phanirithvij?

@phanirithvij
Copy link
Collaborator

If no one publicly is using it then I suggest submitting the project again later when there are some. If it is only privately used does it belong in a public awesome-go list?

I looked at the imported by field like you said. I don't know of any other places.
And I looked the near-zero content in the readme.
And the low amount of interest in the project since its initial commit 7 months ago. (In the form of open issues, prs and stars/bookmarks to your project)

If you are trying to be in the spirit of awesome I suggest again resubmitting later on when it is actually awesome and you follow the full pr template.
I see this is a draft pr but please reopen a PR only after you're done with the changes you said you'd make when you have time.

Please note that I have no intention of personally targeting you or your project but I am simply stating what I see. I apologise if I have offended you.

I will leave this open and let @cassiobotaro handle this pr merging but I am against it in this state.

As I said multiple times I strongly suggest resubmitting after polishing it a lot further.

@xeptore
Copy link
Author

xeptore commented Mar 10, 2024

If you are trying to be in the spirit of awesome I suggest again resubmitting later on when it is actually awesome and you follow the full pr template.

OK, I got the point. Closing.

@xeptore xeptore closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants