Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effdsl #5400

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add effdsl #5400

merged 1 commit into from
Sep 9, 2024

Conversation

sdqri
Copy link
Contributor

@sdqri sdqri commented Sep 7, 2024

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.
  • I removed the following packages around my addition: (please give a short reason for each removal)

Thanks for your PR, you're awesome! 😎

Copy link

github-actions bot commented Sep 7, 2024

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

@yassinebenaid
Copy link
Collaborator

Coverage is low
Screenshot 2024-09-09 at 09 04 58

@sdqri
Copy link
Contributor Author

sdqri commented Sep 9, 2024

Hi @yassinebenaid,
Thank you for taking the time to review and for pointing out the coverage issue. I’ve added more test cases to the project and have increased the coverage to 85%. I'll appreciate your feedback and would be grateful if you could review the updated coverage whenever it's convenient for you.

@yassinebenaid yassinebenaid merged commit c7482f3 into avelino:main Sep 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants