128-feature/show-subject-in-slack-and-telegram

[louisevelayo]

Description

Fixes #128

Changes made

• Add subject argument to send_message functions in both bot_slack.py and bot_telegram.py.

Testing

• Live messages now send a node down message. This is so that our tests can verify that any changes we make do not affect the formatting of the messages on either platform.

Additional comments

• by merging this PR, the format on telegram messages will also be corrected

[mourginakis]

itertools.batched is in python 3.12.

batched was in more-itertools in python 3.11

we could just define batched at the top and then add a todo to delete once python >3.12 becomes standard on all systems and after we update our docker image python version.

[mourginakis]

Here's how I would do it. I'll leave it up to you whether you want to do it this way or not. There is no right answer here.

long_string = "This is a very long string that I want to split into batches of 10 characters."


def batched(iterable, n):
    from itertools import islice
    """Batch data into lists of length *n*. The last batch may be shorter.

    >>> list(batched('ABCDEFG', 3))
    [('A', 'B', 'C'), ('D', 'E', 'F'), ('G',)]

    On Python 3.12 and above, this is an alias for :func:`itertools.batched`.
    """
    if n < 1:
        raise ValueError('n must be at least one')
    it = iter(iterable)
    while True:
        batch = tuple(islice(it, n))
        if not batch:
            break
        yield batch


parts1 = [long_string[i:i+10] for i in range(0, len(long_string), 10)]
print(parts1)
parts2 = ["".join(batch) for batch in batched(long_string, 10)]
print(parts2)

assert parts1 == parts2

[mourginakis]

Let's keep the send_messages() api the same as before, and instead concatenate the subject+message here, before the function gets called.

[mourginakis]

I would recommend defining and using batched here, but i'll let you decide what you want to do. If you decide to keep it this way, please add a comment TODO: use itertools.batched here when python version is updated to >=3.12.

If you decide to define batched here, please add a comment TODO: delete this for itertools.batched when python version is updated to >=3.12.

[mourginakis]

nice!