Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pydantic V2 #155

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Add support for Pydantic V2 #155

merged 1 commit into from
Sep 24, 2023

Conversation

exg
Copy link
Collaborator

@exg exg commented Sep 23, 2023

@aviramha
Copy link
Owner

aviramha commented Sep 23, 2023

Thanks for your contribution!
Before merging this, we need to add tests, similar to what we have in https://github.com/aviramha/ormsgpack/blob/master/tests/test_pydantic.py

@exg
Copy link
Collaborator Author

exg commented Sep 23, 2023

Thanks for your contribution! Before merging this, we need to add tests, similar to what we have in https://github.com/aviramha/ormsgpack/blob/master/tests/test_pydantic.py

What tests do you have in mind? The existing tests cover V2, and pass with my change. Note that the tests use pydantic 2, as the pydantic dependency is not pinned in tests/requirements.txt.

@aviramha
Copy link
Owner

Ah, my mistake - all is good then, just need DCO.

@exg exg merged commit d8b85e9 into aviramha:master Sep 24, 2023
@exg exg deleted the pydantic branch September 24, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants