RavenDB-17793 : throw on attempt to move bucket from prefixed range i…

…f destination shard is not a part of shards list in the prefix setting
aviv86 · Jan 16, 2024 · 12ecc3c · 12ecc3c
1 parent 2650170
commit 12ecc3c
Show file tree

Hide file tree

Showing 3 changed files with 594 additions and 191 deletions.
diff --git a/src/Raven.Server/ServerWide/Commands/Sharding/StartBucketMigrationCommand.cs b/src/Raven.Server/ServerWide/Commands/Sharding/StartBucketMigrationCommand.cs
@@ -55,6 +55,30 @@ public override void UpdateDatabaseRecord(DatabaseRecord record, long etag)
                 }
             }
 
+
+            if (Bucket >= ShardHelper.NumberOfBuckets)
+            {
+                // prefixed bucket range
+                var prefixed = record.Sharding.Prefixed;
+                List<int> shards = null;
+                for (int i = 0; i < prefixed.Count; i++)
+                {
+                    var bucketRangeStart = prefixed[i].BucketRangeStart;
+                    int nextBucketRangeStart = i == prefixed.Count - 1 
+                        ? int.MaxValue 
+                        : prefixed[i + 1].BucketRangeStart;
+
+                    if (Bucket < bucketRangeStart || Bucket >= nextBucketRangeStart) 
+                        continue;
+
+                    shards = prefixed[i].Shards;
+                    break;
+                }
+
+                if (shards == null || shards.Contains(DestinationShard) == false)
+                    throw new RachisApplyException($"Destination shard {DestinationShard} doesn't exists");
+            }
+
             if (record.Sharding.Shards.ContainsKey(DestinationShard) == false)
                 throw new RachisApplyException($"Destination shard {DestinationShard} doesn't exists");