RavenDB-22652 : inter-version tests - add retry mechanism for adding …

…nodes to cluster, in order to avoid test failures due to NoLeaderException
aviv86 · Aug 15, 2024 · c815463 · c815463
1 parent ceb5e9c
commit c815463
Showing 1 changed file with 19 additions and 2 deletions.
diff --git a/test/InterversionTests/MixedClusterTestBase.cs b/test/InterversionTests/MixedClusterTestBase.cs
@@ -61,8 +61,25 @@ protected async Task<List<ProcessNode>> CreateCluster(string[] peers, X509Certif
                     if (processNode == leader)
                         continue;
 
-                    var addCommand = new AddClusterNodeCommand(processNode.Url, watcher: watcherCluster);
-                    await requestExecutor.ExecuteAsync(addCommand, context);
+                    int retries = 5;
+                    while (true)
+                    {
+                        try
+                        {
+                            var addCommand = new AddClusterNodeCommand(processNode.Url, watcher: watcherCluster);
+                            await requestExecutor.ExecuteAsync(addCommand, context);
+                        }
+                        catch (Exception e)
+                        {
+                            if (--retries == 0) 
+                                throw new InvalidOperationException($"failed to add node '{processNode.Url}' to the cluster", e);
+
+                            await Task.Delay(10);
+                            continue;
+                        }
+
+                        break;
+                    }
                 }
 
                 var result = watcherCluster ? (1, peers.Length - 1) : (peers.Length, 0);