-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add api to get approval statuses #1576
Comments
mahalakshme
changed the title
Approval status is not in the api
Add approval status to GET of entities.
Apr 18, 2024
mahalakshme
changed the title
Add approval status to GET of entities.
Add api to get approval statuses
Apr 19, 2024
@1t5j0y if |
1t5j0y
added a commit
to avniproject/avni-server
that referenced
this issue
Apr 23, 2024
1t5j0y
added a commit
to avniproject/avni-server
that referenced
this issue
Apr 24, 2024
Changes from AC to maintain consistency with other APIs:
|
The reason behind use of ID instead of UUID is to not expose internal id to external system. So for the user of api, uuid is the id. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Need:
For integrations like Dalgo, which use APIs to fetch data, they are unable to differentiate the data based on approval status
AC:
api: GET
/api/approvalStatuses
params allowed:
Response Body:
User doesn't have privilege of type: Approve Encounter for encounter type with uuid 'abcd-efgh'
Approval status
field directly mention the value instead of uuidReasons behind some analysis decisions:
/api/subjects
- though the name of the field will say id, value will be uuid. Felt its better to have the name of the field as well as uuid, since CSVs(going to come in near future) and webapp UI have this uuid in the UIThe text was updated successfully, but these errors were encountered: