Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve User & Catchment - sample CSV file #1146

Closed
Tracked by #1545 ...
Parth7223 opened this issue Feb 29, 2024 · 10 comments
Closed
Tracked by #1545 ...

Improve User & Catchment - sample CSV file #1146

Parth7223 opened this issue Feb 29, 2024 · 10 comments
Assignees

Comments

@Parth7223
Copy link

Parth7223 commented Feb 29, 2024

Need:

Several tickets related to CSV have been raised since its usage is not user friendly. Below are some of the issues:

  1. When a user belongs to multiple user groups, they need to be separated by |. But everywhere else generally the separator is ,
    https://avni.freshdesk.com/a/tickets/3902

  2. Even if the needed guidelines are present in readme, it is good to make the app usable for simpler cases as much as possible.

Acceptance criteria:

  • Sample CSV file to be downloaded: Link

    • Header 'Beneficiary ID Prefix' name should be changed to 'Identifier Prefix', Email to 'Email Address', Phone to 'Mobile Number' and 'Language' to 'Preferred Language' in the sample file. (Same as we show in webapp)
    • descriptor row(2nd row) to indicate mandatory fields, allowed values, format of phone number, single/multi value field for language
      - When a sync attribute concept is a coded concept, then mention Allowed values: A,B,C,D in the description row
      - When a sync attribute concept is a numeric concept, then mention Allowed values: any number
      - When a sync attribute concepts is a text concept, then mention Allowed values: any text
    • Sample data to have , separator instead of | for UserGroups column for consistency
    • Screenshot 2024-03-14 at 12 29 21 AM
    • As shown in the above image the sync concept values in the sample file, overflow to the previous column shouldn't happen on the downloaded sample file.
    • Dynamically set the allowed Languages in Description row
    • Dynamically set the possible UserGroups that user can be assigned to in Description row

Ignore the below:

Inputs

  • check the error files for what kind of spelling mistakes people do
  • +91 - need to support outside users as well
  • users and catchments - they upload since they need to do on a continuous basis, locations is a one time thing
  • somewhere give possible location hierarchies - export
  • mandatory fields - symbol to denote mandatory - in location property in 'locations sample file'.
  • no issue with the location hierarchy in the this sample file - so let it remain the same - since they do it by appending the different locations uploaded via locations file.

Questions:

Generating dynamically based on different number of levels is more effort. So add notes like the ones below:
Screenshot 2024-03-14 at 12 57 11 AM

Proposed Behavior: Rather than generating a standard sample CSV for user & catchment across all the project, headers should be populated on the basis of configured values as mentioned below.

  1. 'Location with Hierarchy' should populate the data based on 'Location Types' configured (ex. State>District>Taluk>Village)
  2. Header 'Beneficiary ID Prefix' name should be changed to 'Identifier Prefix'. (Same as UI)
  3. 'Sync Attribute' header should be populated in the sample CSV in case that is part of the UI for any project. (Should not be populated in CSV if not available in UI for any project)
@mahalakshme
Copy link
Contributor

@Parth7223 Sync Attribute' header should be populated in the sample CSV in case that is part of the UI for any project. (Should not be populated in CSV if not available in UI for any project) - this is already working like this

@mahalakshme mahalakshme changed the title User & Catchment - 'Download Sample' should populate the headers which are used to upload the necessary data Improvise User & Catchment - sample CSV file Mar 13, 2024
@vinayvenu vinayvenu unpinned this issue Apr 1, 2024
@mahalakshme mahalakshme removed the enhancement New feature or request label May 7, 2024
@arjunk arjunk changed the title Improvise User & Catchment - sample CSV file Improve User & Catchment - sample CSV file May 8, 2024
@himeshr himeshr self-assigned this May 21, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue May 23, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue May 23, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue May 23, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue May 23, 2024
@himeshr
Copy link
Contributor

himeshr commented May 23, 2024

@mahalakshme
Made code changes to do the following:

  • Dynamically set the allowed Languages in Description row
  • Dynamically set the possible UserGroups that user can be assigned to in Description row

sample-usersAndCatchments - rwb.csv
sample-usersAndCatchments - APF.csv
sample-usersAndCatchments - Goonj.csv

himeshr added a commit to avniproject/avni-server that referenced this issue May 27, 2024
@himeshr
Copy link
Contributor

himeshr commented May 27, 2024

UsersAndCatchement template file after description row changes

test.csv

@mahalakshme
Copy link
Contributor

@himeshr looks good, but found a bug: looks like supported languages and user groups didn't get exported after the above fix.

@himeshr
Copy link
Contributor

himeshr commented May 27, 2024

Oh, my bad, not a bug, uploaded the template file and not the downloaded sample file.

@himeshr looks good, but found a bug: looks like supported languages and user groups didn't get exported after the above fix.

@himeshr
Copy link
Contributor

himeshr commented May 27, 2024

Sample file with description row changes.
sample-usersAndCatchments.csv

@AchalaBelokar
Copy link

  • This card is blocked because sample file header and server side is not match.

@Dinesh2019
Copy link

Dinesh2019 commented Aug 26, 2024

  • Like Preferred language can have the detail only single value is allowed for Track location,Date Picker mode , Enable Beneficiary mode and also for User groups (Multiple value).
  • And also can we have the note or message the file should be updated in the same format because of address we have a format but user might not follow that format so that user can get the error which might leads to confusion.
  • And also for sync attributes we don't have space in between the values

Org : Akrsp,rwbniti
env : staging

Please let me know if u need any clarification on this

@mahalakshme
Copy link
Contributor

@Dinesh2019 for 1 and 2 - The idea is to have description wherever it is confusing and keep it minimal. For Track Location, etc., it is evident that it can have only one value.For UserGroups from egs it is understandable/

  • From eg rows it is implicit that we are trying to convey the format. So should not be an issue

So I think the first two can be skipped. If there are too many descriptions, user might not read it.

himeshr added a commit to avniproject/avni-server that referenced this issue Aug 27, 2024
@himeshr
Copy link
Contributor

himeshr commented Aug 27, 2024

@Dinesh2019 regarding "And also for sync attributes we don't have space in between the values" the possible values as per the sample csv file would now be generated randomly to be one of

  • value1
  • value2
  • value1,value2

The desciption row, contains possible values that could be specified.. Ex: Yes, No
Above example implies that the user can specify following values in the upload file.

  • Yes
  • No
  • Yes,No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

7 participants