Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1142|Export size for locations increased #1202

Closed
wants to merge 1 commit into from

Conversation

ombhardwajj
Copy link
Contributor

This fixes the issue #1142. The default Export size for locations has been increased to 5000!

@ombhardwajj
Copy link
Contributor Author

@vinayvenu Please have a look at this PR!

@vinayvenu
Copy link
Member

This doesn't seem to be working. There are limits set in avni-server that limit the export size to 1000. @mahalakshme what is the best way to proceed here?

@mahalakshme
Copy link
Contributor

@vinayvenu on google, I remember finding some ways to override the default limit exists.

@vinayvenu
Copy link
Member

@mahalakshme I am not sure if there is a way to increase this for a single url. It will be a global change, which can be problematic (see https://docs.spring.io/spring-data/rest/docs/current-SNAPSHOT/reference/html/#getting-started.changing-other-properties). Is it worth it?

@mahalakshme
Copy link
Contributor

mahalakshme commented Jun 4, 2024

@vinayvenu no not at spring level, at react admin level we can override it, found this in some react admin doc,

Tip: The <ExportButton> limits the main request to the dataProvider to 1,000 records. If you want to increase or decrease this limit, pass a maxResults prop to the <ExportButton> in a custom <ListActions> component.

If it applies to export on all pages within admin, I thought it is fine.

Oh thats what ombhardwajj has done. According to their documentation it should work. He can try to timebox and figure out why it doesn't work.

@vinayvenu
Copy link
Member

Closing as this does not work

@vinayvenu vinayvenu closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants