Skip to content

Fix: Prevent duplicate data upload for encounter types without ID column #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Prevent duplicate data upload for encounter types without ID column #1524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/upload/UploadDashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,27 @@ class ReviewStatus {

const isMetadataDiffReviewEnabled = true;

const uploadTypesThatRequireId = [
"Child Test new update registration",
"Pulse Polio enrolment",
"Regular Assessment Encounter",
"Updated type registration"
];

function getCSVHeaders(file) {
return new Promise((resolve, reject) => {
const reader = new FileReader();
reader.onload = event => {
const text = event.target.result;
const lines = text.split("\n");
const headers = lines[0].split(",").map(h => h.trim().replace(/"/g, ""));
resolve(headers);
};
reader.onerror = reject;
reader.readAsText(file);
});
}

const UploadDashboard = ({ getStatuses, getUploadTypes, uploadTypes = new UploadTypes(), userRoles }) => {
const classes = useStyles();

Expand Down Expand Up @@ -123,6 +144,15 @@ const UploadDashboard = ({ getStatuses, getUploadTypes, uploadTypes = new Upload

const handleUploadFile = useCallback(async () => {
try {
if (uploadTypesThatRequireId.includes(uploadType)) {
const headers = await getCSVHeaders(file);
const requiredColumn = "Id from previous system";
if (!headers.includes(requiredColumn)) {
alert(`The uploaded file must contain the "${requiredColumn}" column to prevent duplication.`);
return;
}
}

const locationUploadModeValue = uploadType === UPLOAD_TYPES.LOCATIONS ? locationUploadMode : "";
const encounterUploadModeValue = isEncounterType(uploadType) ? encounterUploadMode : "";
const [ok, error] = await api.bulkUpload(
Expand Down