Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-ASCII string in Tab name #1910

Closed
wants to merge 1 commit into from
Closed

Conversation

zhongsheng
Copy link

#1908
This is my current temporary solution, and there might be better solutions in the future.

@codeclimate
Copy link

codeclimate bot commented Aug 14, 2023

Code Climate has analyzed commit 3db14ed and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

Would you be able to send some tests for it too, please?

@zhongsheng
Copy link
Author

Would you be able to send some tests for it too, please?

I am studying the source code and unfamiliar with rspec. I'm not quite sure where this test should be placed, in the 'system' or 'components' directory?

@github-actions
Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Aug 31, 2023
@github-actions
Copy link
Contributor

Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️

@github-actions github-actions bot closed this Sep 15, 2023
@adrianthedev adrianthedev reopened this Sep 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️

@github-actions github-actions bot closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants