Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: callable filter name and button_label #3382

Merged
merged 2 commits into from
Nov 4, 2024
Merged

feature: callable filter name and button_label #3382

merged 2 commits into from
Nov 4, 2024

Conversation

thiagoyoussef
Copy link
Contributor

@thiagoyoussef thiagoyoussef commented Nov 2, 2024 •
edited
Loading

Description

Fixes #3244
Docs PR: avo-hq/docs.avohq.io#304

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 2, 2024 •
edited
Loading

Code Climate has analyzed commit 146f140 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob added Enhancement Not necessarily a feature, but something has improved and removed Feature labels Nov 4, 2024
Paul-Bob
Paul-Bob approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thiagoyoussef!

This PR is looking great. I'm applying a change that allows access to @arguments inside both, name and button_label.

Otherwise is on point, thank you again @thiagoyoussef

lib/avo/filters/base_filter.rb Outdated Show resolved Hide resolved
@Paul-Bob Paul-Bob merged commit 29795fc into avo-hq:main Nov 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Bob Paul-Bob Paul-Bob approved these changes

Assignees

@thiagoyoussef thiagoyoussef

Labels
Enhancement Not necessarily a feature, but something has improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow proc on filter self.name and self.button_label
2 participants
@thiagoyoussef @Paul-Bob