Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: associations lookup list limit #311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thiagoyoussef
Copy link
Contributor

@thiagoyoussef thiagoyoussef commented Nov 14, 2024

Copy link

netlify bot commented Nov 14, 2024

👷 Deploy request for avo-v2-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 091dc07

@thiagoyoussef thiagoyoussef force-pushed the fix/associations-lookup-list-limit branch from 408d642 to 1f613b5 Compare November 14, 2024 12:09
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a link to the searchable option available in association fields and explain that searchable is more performant and UX-friendly on large data sets.

Besides that, we should add an entry on the upgrade guide (https://docs.avohq.io/3.0/upgrade.html) that mention this new limitation.


## Associations lookup list limit

<VersionReq version="3.14.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.14.0 is the current release version and associations_lookup_list_limitis not included in it.

We do a minor release on the first Tuesday of each month so 3.15.0 will include this feature. However, we’ll soon issue a patch release with some fixes, so it will be available starting from 3.14.1

Suggested change
<VersionReq version="3.14.0" />
<VersionReq version="3.14.1" />

@Paul-Bob
Copy link
Contributor

About the photo let's try to re-frame it to include only valuable content:

image

Also let's mention that the message in the end is available when the limit was indeed reached and that in can be localized with the key avo.key...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent memory bloat in associations when searchable is set to false
2 participants