Skip to content

Commit

Permalink
ras/sosreport.py: Fix errors/false-results
Browse files Browse the repository at this point in the history
Missing: self.sos_cmd = "sos report" for Fedora, Rhel
and CentOS while checking distro name
This was leading to 10 ERRORS, 1 PASS in test-cases
causing FALSE TEST RESULTS
This patch will result in 8 PASS, 1 ERROR, 2 FAILURES

Signed-off-by: Misbah Anjum N <[email protected]>
  • Loading branch information
misanjumn committed Mar 20, 2024
1 parent d9691f2 commit 6d4f678
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ras/sosreport.py
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ def setUp(self):
self.sos_cmd = "sosreport"
elif dist.name in ['rhel', 'centos', 'fedora']:
sos_pkg = 'sos'
self.sos_cmd = "sos report"
else:
self.cancel("sosreport is not supported on %s" % dist.name)
for package in (sos_pkg, 'java'):
if not sm.check_installed(package) and not sm.install(package):
self.cancel(
"Package %s is missing and could not be installed" % (package))
if dist.name == "rhel":
self.sos_cmd = "sos report"
if dist.version <= "7" and dist.release <= "4":
self.sos_cmd = "sosreport"

Expand Down

0 comments on commit 6d4f678

Please sign in to comment.