fixing multipath flush problem in module_load_unload.py #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before fixAfter FIx |
Naresh-ibm
force-pushed
the
module_load_unload_mpath_flush
branch
from
b19cd8d
to
9daf848
Compare
abdhaleegit
requested changes
Feb 15, 2024
io/driver/module_unload_load.py
Outdated
| @@ -98,6 +98,7 @@ def module_load_unload(self, module_list): | |||
| for mod in sub_mod.split(' '): | |||
| if mod == 'multipath': | |||
| if self.flush_mpath(mdl) is False: | |||
| self.error("failed to flush the multipath") | |||
| self.error_modules.append(mdl) | |||
There was a problem hiding this comment.
if the self.error is called,, it will not append in next line.. meaning the test exits
There was a problem hiding this comment.
i say use self.fail instead of self. error
There was a problem hiding this comment.
ahh, that was just a pointer I have added to debug exact issue.
I have removed it. As we are capturing the module in a list and validating at the end of the test.
Hence it is not required here.
just removed that line. please re-check
multipath flush was failing due to string not matching exactly as below, nvme 55964 4 nvme_core 183368 5 nvme we were expecting only : "nvme 55964 4" the first line only. But it is matching all the line that contain the module name. -w option resolve this as below. nvme 55964 4 multipath is added in config file for nvme module. Signed-off-by: Naresh Bannoth <[email protected]>
Naresh-ibm
force-pushed
the
module_load_unload_mpath_flush
branch
from
9daf848
to
1f8ac43
Compare
abdhaleegit
requested changes
Feb 19, 2024
There was a problem hiding this comment.
@Naresh-ibm as praveen said, self.error is a config fail,, and if it is functional fail.. use self.fail, but here self.error_modules is a param.. so we are good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multipath flush was failing due to string not matching exactly as below,
nvme 55964 4
nvme_core 183368 5 nvme
we were expecting only : "nvme 55964 4"
the first line only. But it is matching all the line that contain the module name.
-w option resolve this as below.
nvme 55964 4