dlpar_vscsi: get device node for lscfg #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lscfg -vl do not support device id input, so get the node name for given device id to fix device not found error Signed-off-by: Abdul Haleem <[email protected]>
|
Before fix After fix |
Naresh-ibm
requested changes
Feb 15, 2024
| @@ -34,7 +35,8 @@ def setUp(self): | |||
| Gather necessary test inputs. | |||
| ''' | |||
| device = self.params.get('disk', default=None) | |||
| self.disk = disk.get_absolute_disk_path(device) | |||
| dev_path = disk.get_absolute_disk_path(device) | |||
| self.disk = os.path.basename(os.path.realpath(dev_path)) | |||
There was a problem hiding this comment.
@abdhaleegit what are we trying to achieve here,
>>> disk.get_absolute_disk_path('/dev/sda')
'/dev/sda'
>>>
>>> disk.get_absolute_disk_path('sda')
'/dev/sda'
>>>
>>> os.path.basename(os.path.realpath('/dev/sda'))
'sda'
>>>
# lsscsi
[0:0:1:0] disk AIX VDASD 0001 /dev/sda
[2:0:1:0] disk AIX VDASD 0001 /dev/sdb
====>>> above two disks are vscsi disks
[root@sys avocado-fvt-wrapper]# lsblk -l sda
lsblk: sda: not a block device
[root@sys avocado-fvt-wrapper]#
[root@sys avocado-fvt-wrapper]# lsblk -l /dev/sda
NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
sda 8:0 0 70G 0 disk
sda1 8:1 0 4M 0 part
sda2 8:2 0 1G 0 part /boot
sda3 8:3 0 69G 0 part
rhel_sys-root 253:0 0 41.7G 0 lvm /
rhel_sys-swap 253:1 0 7G 0 lvm [SWAP]
rhel_sys-home 253:2 0 20.3G 0 lvm /home
[root@sys avocado-fvt-wrapper]#
I feel the older way itself working fine.
can you please re-check on this
There was a problem hiding this comment.
@Naresh-ibm my input here is /dev/disk/by-id/scsi-SAIX_VDASD_00fbecf500004b0000000185a73de2a2.2 so the test were failing
There was a problem hiding this comment.
all our input to test are device by id for persistent device name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lscfg -vl do not support device id input, so
get the node name for given device id to fix
device not found error