Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inspekt errors for TravisCI build #2777

Closed

Conversation

misanjumn
Copy link
Contributor

@misanjumn misanjumn commented Mar 20, 2024

Fix inspekt errors for TravisCI build

  • TravisCI build is failing for new PRs due to bad
    python code formatting on some programs.

  • This patch will fix the inspekt errors so
    that new TravisCI PR builds will pass

Formatting includes: multi-import, whitespaces,
line formatting and basic redundancy errors

Signed-off-by: Misbah Anjum N [email protected]

@misanjumn
Copy link
Contributor Author

misanjumn commented Mar 20, 2024

Hi,

The Patches,
PR#2776: ras/sosreport.py: Fix errors/false-results,
PR#2779: trace: Add Fedora Support to trace testing,
are dependent on this PR for the TravisCI builds to PASS.

Please kindly look into it.
Thanks.

@PraveenPenguin
Copy link
Member

PraveenPenguin commented Mar 21, 2024

@misanjumn can you rebase this as infra i did fixed now travis CI ,can please send patch as style fix

@misanjumn
Copy link
Contributor Author

@misanjumn can you rebase this as infra i did fixed now travis CI ,can please send patch as style fix

@PraveenPenguin There are merge conflicts arising with rebase.
Because the commit Fixed travis failure due to indendation has the same code change.

@PraveenPenguin
Copy link
Member

yes , that's why requesting please rebase

TravisCI build is failing for new PRs due to bad
python code formatting.
This patch will fix the inspekt errors fsx.py so
that new TravisCI PR builds will pass

Formatting includes: multi-import, whitespaces,
line formatting and basic redundancy errors

Signed-off-by: Misbah Anjum N <[email protected]>
@misanjumn misanjumn changed the title fs/fsx.py: Fix inspekt errors for TravisCI build Fix inspekt errors for TravisCI build Mar 21, 2024
@misanjumn
Copy link
Contributor Author

yes , that's why requesting please rebase

Yes, I have rebased now
This will fix all TravisCI errors,
Thanks

@misanjumn misanjumn closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants