Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RX TX queue tuning before running iperf test #2780

Merged
merged 1 commit into from
Apr 24, 2024
Merged

RX TX queue tuning before running iperf test #2780

merged 1 commit into from
Apr 24, 2024

Conversation

vaishnavibhat
Copy link
Contributor

The patch enables runnign of irqbalance service, tuning rx tx queue values before starting iperf tests.

The command to run iperf test from client side is improvised to include parallel threads, interval between periodic bandwidth reports and time in seconds to transmit for values

@PraveenPenguin
Copy link
Member

@vaishnavibhat can you please rebase as we have issue in Travis CI which was address in other commit

@abdhaleegit abdhaleegit self-requested a review March 28, 2024 04:09
abdhaleegit
abdhaleegit requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaishnavibhat 2 questions

  1. are these changes applicable for all type of devices or only vnic
  2. should other performance test requires similar change... in that case move some code can be moved to common like enable irq and tune

io/net/iperf_test.py Outdated Show resolved Hide resolved
io/net/iperf_test.py Outdated Show resolved Hide resolved
@vaishnavibhat
Copy link
Contributor Author

@vaishnavibhat 2 questions

  1. are these changes applicable for all type of devices or only vnic
  2. should other performance test requires similar change... in that case move some code can be moved to common like enable irq and tune

Yes, sending patch to include the change in netperf and uperf test cases

@abdhaleegit
Copy link
Collaborator

  1. move ethtool rx tx settings to individual test
  2. and perf specific values settings to iperf and netperf test
  3. common utils like irqbalance to utils

@abdhaleegit abdhaleegit self-assigned this Apr 1, 2024
@vaishnavibhat vaishnavibhat force-pushed the performance_tune branch 2 times, most recently from 4a8b21c to 9e86647 Compare April 2, 2024 18:27
@vaishnavibhat
Copy link
Contributor Author

vaishnavibhat commented Apr 2, 2024 •
edited by abdhaleegit
Loading

avocado run iperf_test.py -m iperf_virt_test.yaml --max-parallel-tasks=1
JOB ID : 62add810eb852020230ddc2d3dc7ae96a8d52d6c
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-04-03T00.12-62add81/job.log
(1/2) iperf_test.py:Iperf.test;run-mtu-1500-8a94: STARTED
(1/2) iperf_test.py:Iperf.test;run-mtu-1500-8a94: PASS (53.51 s)
(2/2) iperf_test.py:Iperf.test;run-mtu-9000-92c4: STARTED
(2/2) iperf_test.py:Iperf.test;run-mtu-9000-92c4: FAIL: FAIL: Throughput Actual - 68.0%, Expected - 80%, Throughput Actual value - 17000Mb/sec (64.77 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-04-03T00.12-62add81/results.html
JOB TIME : 137.05 s

Test summary:
2-iperf_test.py:Iperf.test;run-mtu-9000-92c4: FAIL

debug.log

debug.log

[job.log]

@abdhaleegit
Copy link
Collaborator

@vaishnavibhat an existing utils for is_vnic https://github.com/avocado-framework/avocado/blob/76199b2472363dc5963c7dc8636ca47c2250a4db/avocado/utils/network/interfaces.py#L633

@abdhaleegit
Copy link
Collaborator

@vaishnavibhat anyting pending on this ? I see the existing is_vnic utils unused

@vaishnavibhat
Copy link
Contributor Author

@vaishnavibhat anyting pending on this ? I see the existing is_vnic utils unused

Taken care of the changes to include the utils is_vnic()

@abdhaleegit abdhaleegit self-requested a review April 19, 2024 10:20
abdhaleegit
abdhaleegit approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PraveenPenguin
Copy link
Member

@vaishnavibhat please rebase PR , and address CI failure

@vaishnavibhat
RX TX queue tuning before running iperf test
334b3f5 
Patch enables runnign of irqbalance service, tuning rx tx queue values before starting iperf tests.

The command to run iperf test from client side is improvised to include parallel threads,
interval between periodic bandwidth reports and time in seconds to transmit for values

Signed-off-by: Vaishnavi Bhat <[email protected]>
@abdhaleegit abdhaleegit self-requested a review April 23, 2024 10:31
abdhaleegit
abdhaleegit approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@abdhaleegit abdhaleegit merged commit 953ea40 into avocado-framework-tests:master Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdhaleegit abdhaleegit abdhaleegit approved these changes

Assignees

@abdhaleegit abdhaleegit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaishnavibhat @PraveenPenguin @abdhaleegit