Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Fix false results and add Fedora support #2784

Merged

Conversation

misanjumn
Copy link
Contributor

perf: Fix false results and add Fedora support

Updated perf tests to enable fedora testing

This patch will also enable "perf test" failures
which were earlier cancelled due to missing
"fedora" support in distro.detect()

Signed-off-by: Misbah Anjum N [email protected]

Updated perf tests to enable fedora testing

This patch will also enable "perf test" failures
which were earlier cancelled due to missing
"fedora" support in distro.detect()

Signed-off-by: Misbah Anjum N <[email protected]>
@misanjumn
Copy link
Contributor Author

Testing on OS: Fedora40

Without the patch

CANCEL: 2
ERROR: 1

(1/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_duplicate_probe.py:PerfDuplicateProbe.test_duplicate_probe: STARTED
 (1/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_duplicate_probe.py:PerfDuplicateProbe.test_duplicate_probe:  CANCEL: Install the package for perf supported                      by fedora (0.77 s)
 (2/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_script_bug.py:PerfScript.test_script_probe: STARTED
 (2/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_script_bug.py:PerfScript.test_script_probe:  ERROR: No section: 'fedora' (0.01 s)
 (3/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_test.py:Perftest.test_perf_test: STARTED
 (3/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_test.py:Perftest.test_perf_test:  CANCEL: perf-debuginfo is needed for the test to be run (3.04 s)
RESULTS    : PASS 0 | ERROR 1 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 2

With the patch

FAIL: 1
PASS: 2

 (1/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_duplicate_probe.py:PerfDuplicateProbe.test_duplicate_probe: STARTED
 (1/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_duplicate_probe.py:PerfDuplicateProbe.test_duplicate_probe:  PASS (0.75 s)
 (2/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_script_bug.py:PerfScript.test_script_probe: STARTED
 (2/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_script_bug.py:PerfScript.test_script_probe:  PASS (1.81 s)
 (3/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_test.py:Perftest.test_perf_test: STARTED
 (3/3) /home/misanjumn/tests/tests/avocado-misc-tests/perf/perf_test.py:Perftest.test_perf_test:  FAIL: 4 Test failed (27.17 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

perf_test.py

OS: Fedora40
command: perf test
Test: perf/perf_test.py:Perftest.test_perf_test
Without the patch: CANCEL
With the patch: 4 FAIL Test-cases

Copy link
Contributor

@disgoel disgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PraveenPenguin PraveenPenguin merged commit 85d0121 into avocado-framework-tests:master Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants