Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/ppc64_cpu: single core plus smt and upstream as a target #2788

Merged
merged 2 commits into from
May 6, 2024

Conversation

sacsant
Copy link
Contributor

@sacsant sacsant commented Mar 29, 2024

This two patch series add following support:

Add upstream as a target for ppc64_cpu test
Add capabilities to download and compile upstream source for
powerpc-utils tools(ppc64_cpu).
Add a test case to validate following scenario:
A system with single online core along with consecutive smt
level change to ensure number of online cores do not change

Signed-off-by: Sachin Sant [email protected]

Add a test case to validate following scenario:
   A system with single online core along with consecutive smt
   level change to ensure number of online cores do not change

Signed-off-by: Sachin Sant <[email protected]>
@sacsant
Copy link
Contributor Author

sacsant commented Mar 29, 2024

With patch

(1/3) cpu/ppc64_cpu_test.py:PPC64Test.test_cmd_options: STARTED
(1/3) cpu/ppc64_cpu_test.py:PPC64Test.test_cmd_options: PASS (110.51 s)
(2/3) cpu/ppc64_cpu_test.py:PPC64Test.test_smt_loop: STARTED
(2/3) cpu/ppc64_cpu_test.py:PPC64Test.test_smt_loop: PASS (336.67 s)
(3/3) cpu/ppc64_cpu_test.py:PPC64Test.test_single_core_smt: STARTED
(3/3) cpu/ppc64_cpu_test.py:PPC64Test.test_single_core_smt: PASS (101.84 s)

@sacsant
Copy link
Contributor Author

sacsant commented Mar 29, 2024

On systems (with a specific version of powerpc utils) where the test case should catch the defect, the test as expected fails

(1/3) cpu/ppc64_cpu_test.py:PPC64Test.test_cmd_options: STARTED
(1/3) cpu/ppc64_cpu_test.py:PPC64Test.test_cmd_options: PASS (110.51 s)
(2/3) cpu/ppc64_cpu_test.py:PPC64Test.test_smt_loop: STARTED
(2/3) cpu/ppc64_cpu_test.py:PPC64Test.test_smt_loop: PASS (2899.51 s)
(3/3) cpu/ppc64_cpu_test.py:PPC64Test.test_single_core_smt: STARTED
(3/3) cpu/ppc64_cpu_test.py:PPC64Test.test_single_core_smt: FAIL: SMT with Single core test failed (111.91 s)

@sacsant sacsant changed the title cpu/ppc64_cpu: SMT change with one online core test cpu/ppc64_cpu: single core plus smt and upstream as a target Apr 15, 2024
@sacsant
Copy link
Contributor Author

sacsant commented Apr 15, 2024

With patch and upstream as a target:

avocado run --max-parallel-tasks=1 cpu/ppc64_cpu_test.py -m cpu/ppc64_cpu_test.py.data/upstream.yaml
Fetching asset from cpu/ppc64_cpu_test.py:PPC64Test.test_build_upstream
......
(1/4) cpu/ppc64_cpu_test.py:PPC64Test.test_build_upstream;run-run_type-upstream-5b1b: STARTED
(1/4) cpu/ppc64_cpu_test.py:PPC64Test.test_build_upstream;run-run_type-upstream-5b1b: PASS (47.06 s)
(2/4) cpu/ppc64_cpu_test.py:PPC64Test.test_cmd_options;run-run_type-upstream-5b1b: STARTED
(2/4) cpu/ppc64_cpu_test.py:PPC64Test.test_cmd_options;run-run_type-upstream-5b1b: PASS (60.25 s)
(3/4) cpu/ppc64_cpu_test.py:PPC64Test.test_smt_loop;run-run_type-upstream-5b1b: STARTED
(3/4) cpu/ppc64_cpu_test.py:PPC64Test.test_smt_loop;run-run_type-upstream-5b1b: PASS (63.03 s)
(4/4) cpu/ppc64_cpu_test.py:PPC64Test.test_single_core_smt;run-run_type-upstream-5b1b: STARTED
(4/4) cpu/ppc64_cpu_test.py:PPC64Test.test_single_core_smt;run-run_type-upstream-5b1b: FAIL: SMT with Single core test failed (62.69 s)

With patch and distro as a target:

avocado run --max-parallel-tasks=1 cpu/ppc64_cpu_test.py
.....
(1/4) cpu/ppc64_cpu_test.py:PPC64Test.test_build_upstream: STARTED
(1/4) cpu/ppc64_cpu_test.py:PPC64Test.test_build_upstream: CANCEL: This test is supported with upstream as target (45.79 s)
(2/4) cpu/ppc64_cpu_test.py:PPC64Test.test_cmd_options: STARTED
(2/4) cpu/ppc64_cpu_test.py:PPC64Test.test_cmd_options: PASS (65.48 s)
(3/4) cpu/ppc64_cpu_test.py:PPC64Test.test_smt_loop: STARTED
(3/4) cpu/ppc64_cpu_test.py:PPC64Test.test_smt_loop: PASS (64.50 s)
(4/4) cpu/ppc64_cpu_test.py:PPC64Test.test_single_core_smt: STARTED
(4/4) cpu/ppc64_cpu_test.py:PPC64Test.test_single_core_smt: FAIL: SMT with Single core test failed (68.80 s)

@abdhaleegit abdhaleegit self-requested a review April 19, 2024 09:41
cpu/ppc64_cpu_test.py Outdated Show resolved Hide resolved
cpu/ppc64_cpu_test.py Show resolved Hide resolved
Add capabilities to download and compile upstream source for
powerpc-utils tools(ppc64_cpu).

Signed-off-by: Sachin Sant <[email protected]>
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdhaleegit abdhaleegit merged commit c1a189e into avocado-framework-tests:master May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants