Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf/perf_24x7: fix domain and core values #2808

Merged
merged 1 commit into from
Jun 8, 2024
Merged

perf/perf_24x7: fix domain and core values #2808

merged 1 commit into from
Jun 8, 2024

Conversation

disgoel
Copy link
Contributor

@disgoel disgoel commented Apr 24, 2024 •
edited
Loading

This patch changes the logic to run domain=2 with physical cores and domain>2 with virtual cores available in the lpar.
Reference for above changes:
1: Physical Chip
2: Physical Core
3: VCPU Home Core
4: VCPU Home Chip
5: VCPU Home Node
6: VCPU Remote Node

Also integrated getting core and chip values directly from cpu.lscpu from avocado utils.

avocado run --max-parallel-tasks=1 perf_24x7_hardware_counters.py
JOB ID     : 022e5a78dd28c7deeccde4f8a90e005958883273
JOB LOG    : /home/avocado-fvt-wrapper/results/job-2024-04-24T07.17-022e5a7/job.log
 (01/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_display_domain_indices_in_sysfs: STARTED
 (01/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_display_domain_indices_in_sysfs: PASS (1.32 s)
 (02/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_phys_core_param: STARTED
 (02/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_phys_core_param: CANCEL: HPM_0THRD_NON_IDLE_CCYC__PHYS_CORE not found (5.73 s)
 (03/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_wo_domain_param: STARTED
 (03/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_wo_domain_param: PASS (1.33 s)
 (04/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_all_domains: STARTED
 (04/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_all_domains: PASS (26.63 s)
 (05/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_domains: STARTED
 (05/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_domains: PASS (3.36 s)
 (06/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_core: STARTED
 (06/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_core: PASS (1.33 s)
 (07/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_w_chip_param: STARTED
 (07/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_w_chip_param: PASS (1.32 s)
 (08/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_wo_chip_param: STARTED
 (08/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_wo_chip_param: PASS (1.34 s)
 (09/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_valid_chip: STARTED
 (09/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_valid_chip: PASS (1.37 s)
 (10/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_chip: STARTED
 (10/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_chip: PASS (1.34 s)
 (11/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_domain_chip_offset: STARTED
 (11/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_domain_chip_offset: PASS (101.54 s)
 (12/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_helper_phys_core: STARTED
 (12/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_helper_phys_core: PASS (1.35 s)
 (13/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_helper_vcpu: STARTED
 (13/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_helper_vcpu: PASS (1.34 s)
RESULTS    : PASS 12 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 1
JOB HTML   : /home/avocado-fvt-wrapper/results/job-2024-04-24T07.17-022e5a7/results.html
JOB TIME   : 242.99 s

avocado run perf_24x7_all_events.py
JOB ID     : 5c9e19e40c1b3d5dcabb3ebf664b45dc7499d60f
JOB LOG    : /home/avocado-fvt-wrapper/results/job-2024-04-24T23.39-5c9e19e/job.log
 (1/1) perf_24x7_all_events.py:hv_24x7_all_events.test_all_events: STARTED
 (1/1) perf_24x7_all_events.py:hv_24x7_all_events.test_all_events: PASS (1184.11 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /home/avocado-fvt-wrapper/results/job-2024-04-24T23.39-5c9e19e/results.html
JOB TIME   : 1202.60 s

@disgoel
Copy link
Contributor Author

disgoel commented Apr 24, 2024

This PR depends on avocado-framework/avocado#5916

@Naresh-ibm Naresh-ibm self-assigned this Apr 25, 2024
@disgoel disgoel marked this pull request as draft June 3, 2024 06:17
@disgoel disgoel mentioned this pull request Jun 7, 2024
Closed
@disgoel
perf/perf_24x7: fix domain and core values
155f139 
This patch changes the logic to run domain=2 with physical cores
and domain>2 with virtual cores available in the lpar.

Reference for above changes:
1: Physical Chip
2: Physical Core
3: VCPU Home Core
4: VCPU Home Chip
5: VCPU Home Node
6: VCPU Remote Node

Also integrated getting core and chip values directly from
cpu.lscpu from avocado utils.

Signed-off-by: Disha Goel <[email protected]>
@disgoel disgoel mentioned this pull request Jun 7, 2024
Merged
@disgoel
Copy link
Contributor Author

disgoel commented Jun 7, 2024 •
edited
Loading

Incorporated changes suggested by Kajol in PR #2705

Sent PR in avocado utils to fix getting physical core value correctly
avocado-framework/avocado#5947

@disgoel disgoel marked this pull request as ready for review June 7, 2024 12:52
@disgoel
Copy link
Contributor Author

disgoel commented Jun 7, 2024 

avocado run --max-parallel-tasks=1 perf_24x7_hardware_counters.py
JOB ID     : afbfaa6b2c6eeb3d7dfaff6f95fbdcfece5c549c
JOB LOG    : /home/avocado-fvt-wrapper/results/job-2024-06-07T08.40-afbfaa6/job.log
 (01/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_display_domain_indices_in_sysfs: STARTED
 (01/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_display_domain_indices_in_sysfs: PASS (1.17 s)
 (02/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_phys_core_param: STARTED
 (02/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_phys_core_param: CANCEL: HPM_0THRD_NON_IDLE_CCYC__PHYS_CORE not found (25.68 s)
 (03/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_wo_domain_param: STARTED
 (03/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_wo_domain_param: PASS (1.18 s)
 (04/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_all_domains: STARTED
 (04/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_all_domains: PASS (50.23 s)
 (05/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_domains: STARTED
 (05/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_domains: PASS (3.23 s)
 (06/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_core: STARTED
 (06/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_core: PASS (1.18 s)
 (07/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_w_chip_param: STARTED
 (07/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_w_chip_param: PASS (1.16 s)
 (08/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_wo_chip_param: STARTED
 (08/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_wo_chip_param: PASS (1.18 s)
 (09/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_valid_chip: STARTED
 (09/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_valid_chip: PASS (1.25 s)
 (10/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_chip: STARTED
 (10/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_check_invalid_chip: PASS (1.21 s)
 (11/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_domain_chip_offset: STARTED
 (11/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_domain_chip_offset: PASS (101.56 s)
 (12/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_helper_phys_core: STARTED
 (12/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_helper_phys_core: PASS (1.22 s)
 (13/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_helper_vcpu: STARTED
 (13/13) perf_24x7_hardware_counters.py:EliminateDomainSuffix.test_event_helper_vcpu: PASS (1.23 s)
RESULTS    : PASS 12 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 1
JOB HTML   : /home/avocado-fvt-wrapper/results/job-2024-06-07T08.40-afbfaa6/results.html
JOB TIME   : 315.33 s

avocado run --max-parallel-tasks=1 perf_24x7_all_events.py
JOB ID     : ea80e70c85d68b8612961584a5fc68290a6c6a9d
JOB LOG    : /home/avocado-fvt-wrapper/results/job-2024-06-07T06.50-ea80e70/job.log
 (1/1) perf_24x7_all_events.py:hv_24x7_all_events.test_all_events: STARTED
 (1/1) perf_24x7_all_events.py:hv_24x7_all_events.test_all_events: PASS (4224.73 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /home/avocado-fvt-wrapper/results/job-2024-06-07T06.50-ea80e70/results.html
JOB TIME   : 4245.85 s

@PraveenPenguin PraveenPenguin merged commit 238adc7 into avocado-framework-tests:master Jun 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraveenPenguin PraveenPenguin PraveenPenguin approved these changes

@abdhaleegit abdhaleegit Awaiting requested review from abdhaleegit

Assignees

@Naresh-ibm Naresh-ibm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disgoel @PraveenPenguin @Naresh-ibm