set the queue length to original values after test #2893
Conversation
|
Before test: During test: ethtool -l eth1 After test: (value reset back to original queue length) |
|
avocado run ethtool_test.py -m ethtool_vnic_test.yaml --max-parallel-tasks=1 |
io/net/ethtool_test.py
Outdated
| cmd = "ethtool %s %s %s %s %s %s %s %s %s %s" % ( | ||
| self.args, self.interface, self.param[0], self.default_set[0], | ||
| self.param[1], self.default_set[1], self.param[2], | ||
| self.default_set[2], self.param[3], self.default_set[3]) |
There was a problem hiding this comment.
@vaishnavibhat can you re-frame this as below,
cmd = f"ethtool {self.args} {self.interface} {self.param[0]} {self.default_set[0]}
{ self.param[1]} {self.default_set[1]} {self.param[2]} {self.default_set[2]} {self.param[3]}
{self.default_set[3])}"
This will help, not to miss any parameter and reference to the variables.
io/net/ethtool_test.py
Outdated
| ret = process.run(cmd, shell=True, verbose=True, | ||
| ignore_status=True) | ||
| if ret.exit_status != 0: | ||
| self.fail("%s %s" % (self.args, ret.stderr_text)) |
|
@vaishnavibhat can you please re-push the code with suggestion? |
vaishnavibhat
force-pushed
the
ethtool_fix
branch
from
c7924a3
to
e8bb068
Compare
ethtool -L option tests for different rx and tx length. The patch works on retrieving the original values for the interface and setting the rx and tx values to original values after the test. Signed-off-by: Vaishnavi Bhat <[email protected]>
vaishnavibhat
force-pushed
the
ethtool_fix
branch
from
e8bb068
to
3c06795
Compare
| #self.fail("%s %s" % (self.args, ret.stderr_text)) | ||
| self.fail(f"{self.args} {ret.stderr_text}") | ||
| # Set queue values to original values | ||
| #cmd = "ethtool %s %s %s %s %s %s %s %s %s %s" % ( |
There was a problem hiding this comment.
@vaishnavibhat Thanks for incorporating the changes, can you please remove the commented lines?
ethtool -L option tests for different rx and tx length. The patch works on retrieving the original values for the interface and setting the rx and tx values to original values after the test.