utils.astring: A couple of strip_console_codes fixes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukáš Doktor <[email protected]>
we already set the "index += len(tmp_word) + 1" before we get to this exception so we must not add the tmp_index. Signed-off-by: Lukáš Doktor <[email protected]>
previously we only checked the console_code is found anywhere in the text between the two \x1b and then we blindly removed first N characters. Let's ensure we check the console code regexp from the beginning. Signed-off-by: Lukáš Doktor <[email protected]>
|
Though I might be misunderstanding but matching only the start of a line doesn't seem to work, ref. #134 (comment) |
these are sometimes generated by kernel, ignore them. Signed-off-by: Lukáš Doktor <[email protected]> Signed-off-by: Sebastian Mitterle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the strip_console_code works quite oddly, let's add a selftest and fix the biggest issues.
Anyway the behaviour was here for a long time so this is here just to begin some discussion.
do not merge before a proper discussion!