qdevices: bug fixing #3710

nickzhq · 2023-06-20T02:29:27Z

Do not change the type of "detect-zeroes" in -blockdev for json format

ID: 2216076

nickzhq · 2023-06-20T06:02:06Z

@YongxueHong @zhencliu @qingwangrh please take a look! Thanks!

virttest/qemu_devices/qdevices.py

zhencliu · 2023-06-20T07:06:04Z

it's better to revise the commit header, e.g.
qdevices: type of detect-zeroes should be a string

You may paste the valid values from man page in the commit body

qingwangrh · 2023-06-20T07:18:02Z

(1/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.off.q35: STARTED
(1/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.off.q35: PASS (48.95 s)
(2/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.on.q35: STARTED
(2/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.on.q35: PASS (47.65 s)
(3/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.unmap.q35: STARTED
(3/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.unmap.q35: PASS (47.60 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCE

LGTM

nickzhq · 2023-06-20T07:43:36Z

@YongxueHong @zhencliu please take a look! Thanks!

YongxueHong · 2023-06-20T08:03:30Z

(1/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.off.q35: STARTED (1/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.off.q35: PASS (48.95 s) (2/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.on.q35: STARTED (2/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.on.q35: PASS (47.65 s) (3/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.unmap.q35: STARTED (3/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.unmap.q35: PASS (47.60 s) RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCE

LGTM

Hi @qingwangrh
Could you help to paste the related command line?
Thanks.

zhencliu · 2023-06-20T08:07:07Z

(1/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.off.q35: STARTED (1/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.off.q35: PASS (48.95 s) (2/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.on.q35: STARTED (2/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.on.q35: PASS (47.65 s) (3/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.unmap.q35: STARTED (3/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.unmap.q35: PASS (47.60 s) RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCE

LGTM

Hi @qingwangrh , do we plan to add a hotplug case with the option 'detect-zeroes'? It looks block_detect_zeroes is a new case which is not in upstream yet. If it is, talked with @YongxueHong , we may also need to run the hotplug case, as Nick's code change can also affect the hotplug function cc @nickzhq , thanks.

virttest/qemu_devices/qdevices.py

qingwangrh · 2023-06-20T09:12:35Z

(1/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.off.q35: STARTED (1/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.off.q35: PASS (48.95 s) (2/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.on.q35: STARTED (2/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.on.q35: PASS (47.65 s) (3/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.unmap.q35: STARTED (3/3) Host_RHEL.m8.u5.product_av.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.4.0.x86_64.io-github-autotest-qemu.block_detect_zeroes.unmap.q35: PASS (47.60 s) RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCE
LGTM

Hi @qingwangrh , do we plan to add a hotplug case with the option 'detect-zeroes'? It looks block_detect_zeroes is a new case which is not in upstream yet. If it is, talked with @YongxueHong , we may also need to run the hotplug case, as Nick's code change can also affect the hotplug function cc @nickzhq , thanks.

@YongxueHong the command line
python ConfigTest.py --testcase=block_detect_zeroes --guestname=RHEL.8.4.0 --clone=no --firmware=default_bios
It is a new case not exist upstream.
@zhencliu it is a new case boot vm with the disk has detect-zeroes option, it does not include hotplug operation. maybe it is another story, i may develop a new case to hotplug .

qingwangrh · 2023-06-20T10:07:57Z

Test hotplug with this patch, it looks like run the correct QMP command :
(monitor avocado-vt-vm1.qmpmonitor1) Sending command 'blockdev-add'
[stdlog] 2023-06-20 06:04:50,206 qemu_monitor L2007 DEBUG| Send command: {'execute': 'blockdev-add', 'arguments': {'node-name': 'file_stg1', 'driver': 'file', 'auto-read-only': True, 'discard': 'unmap', 'aio': 'threads', 'filename': '/home/kvm_autotest_root/images/stg1.qcow2', 'cache': {'direct': True, 'no-flush': False}, 'detect-zeroes': 'on'}, 'id': 'pr7cbRsh'}
[stdlog] 2023-06-20 06:04:50,287 qemu_monitor L0443 DEBUG| (monitor avocado-vt-vm1.qmpmonitor1) Sending command 'blockdev-add'
[stdlog] 2023-06-20 06:04:50,287 qemu_monitor L2007 DEBUG| Send command: {'execute': 'blockdev-add', 'arguments': {'node-name': 'drive_stg1', 'driver': 'qcow2', 'read-only': False, 'cache': {'direct': True, 'no-flush': False}, 'file': 'file_stg1', 'discard': 'unmap', 'detect-zeroes': 'on'}, 'id': 'TCNLalBV'}
[stdlog] 2023-06-20 06:04:50,319 qemu_monitor L0443 DEBUG| (monitor avocado-vt-vm1.qmpmonitor1) Sending command 'device_add'
[stdlog] 2023-06-20 06:04:50,319 qemu_monitor L2007 DEBUG| Send command: {'execute': 'device_add', 'arguments': OrderedDict([('driver', 'scsi-hd'), ('id', 'stg1'), ('drive', 'drive_stg1'), ('write-cache', 'on'), ('serial', 'stg1'), ('bus', 'virtio_scsi_pci0.0')]), 'id': 'axaxDwKb'}

zhencliu · 2023-06-20T12:30:29Z

Test hotplug with this patch, it looks like run the correct QMP command : (monitor avocado-vt-vm1.qmpmonitor1) Sending command 'blockdev-add' [stdlog] 2023-06-20 06:04:50,206 qemu_monitor L2007 DEBUG| Send command: {'execute': 'blockdev-add', 'arguments': {'node-name': 'file_stg1', 'driver': 'file', 'auto-read-only': True, 'discard': 'unmap', 'aio': 'threads', 'filename': '/home/kvm_autotest_root/images/stg1.qcow2', 'cache': {'direct': True, 'no-flush': False}, 'detect-zeroes': 'on'}, 'id': 'pr7cbRsh'} [stdlog] 2023-06-20 06:04:50,287 qemu_monitor L0443 DEBUG| (monitor avocado-vt-vm1.qmpmonitor1) Sending command 'blockdev-add' [stdlog] 2023-06-20 06:04:50,287 qemu_monitor L2007 DEBUG| Send command: {'execute': 'blockdev-add', 'arguments': {'node-name': 'drive_stg1', 'driver': 'qcow2', 'read-only': False, 'cache': {'direct': True, 'no-flush': False}, 'file': 'file_stg1', 'discard': 'unmap', 'detect-zeroes': 'on'}, 'id': 'TCNLalBV'} [stdlog] 2023-06-20 06:04:50,319 qemu_monitor L0443 DEBUG| (monitor avocado-vt-vm1.qmpmonitor1) Sending command 'device_add' [stdlog] 2023-06-20 06:04:50,319 qemu_monitor L2007 DEBUG| Send command: {'execute': 'device_add', 'arguments': OrderedDict([('driver', 'scsi-hd'), ('id', 'stg1'), ('drive', 'drive_stg1'), ('write-cache', 'on'), ('serial', 'stg1'), ('bus', 'virtio_scsi_pci0.0')]), 'id': 'axaxDwKb'}

Thanks for the information.

virttest/qemu_devices/qdevices.py

values of "detect-zeroes" should be one of ["on", "off", "unmap"] Signed-off-by: Houqi (Nick) Zuo <[email protected]>

YongxueHong

LGTM.

YongxueHong reviewed Jun 20, 2023

View reviewed changes

virttest/qemu_devices/qdevices.py Outdated Show resolved Hide resolved

nickzhq force-pushed the detect_zeros branch from 2537d99 to f918d1c Compare June 20, 2023 07:43

YongxueHong reviewed Jun 20, 2023

View reviewed changes

virttest/qemu_devices/qdevices.py Outdated Show resolved Hide resolved

nickzhq force-pushed the detect_zeros branch from f918d1c to d268e8e Compare June 20, 2023 09:28

qingwangrh mentioned this pull request Jun 21, 2023

Add blockdev detect-zeroes option test case autotest/tp-qemu#3754

Merged

YongxueHong reviewed Jun 26, 2023

View reviewed changes

virttest/qemu_devices/qdevices.py Outdated Show resolved Hide resolved

qdevices: type of detect-zeroes should be a string

d532ac7

values of "detect-zeroes" should be one of ["on", "off", "unmap"] Signed-off-by: Houqi (Nick) Zuo <[email protected]>

nickzhq force-pushed the detect_zeros branch from d268e8e to d532ac7 Compare June 26, 2023 09:14

zhencliu approved these changes Jun 26, 2023

View reviewed changes

YongxueHong approved these changes Jun 26, 2023

View reviewed changes

YongxueHong merged commit fdcfdde into avocado-framework:master Jun 27, 2023
49 checks passed

YongxueHong mentioned this pull request Sep 22, 2023

qdevices: Fix the missing of the detect-zeroes #3771

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qdevices: bug fixing #3710

qdevices: bug fixing #3710

nickzhq commented Jun 20, 2023 •

edited

Loading

nickzhq commented Jun 20, 2023

zhencliu commented Jun 20, 2023

qingwangrh commented Jun 20, 2023

nickzhq commented Jun 20, 2023

YongxueHong commented Jun 20, 2023

zhencliu commented Jun 20, 2023

qingwangrh commented Jun 20, 2023 •

edited

Loading

qingwangrh commented Jun 20, 2023

zhencliu commented Jun 20, 2023

YongxueHong left a comment

qdevices: bug fixing #3710

qdevices: bug fixing #3710

Conversation

nickzhq commented Jun 20, 2023 • edited Loading

nickzhq commented Jun 20, 2023

zhencliu commented Jun 20, 2023

qingwangrh commented Jun 20, 2023

nickzhq commented Jun 20, 2023

YongxueHong commented Jun 20, 2023

zhencliu commented Jun 20, 2023

qingwangrh commented Jun 20, 2023 • edited Loading

qingwangrh commented Jun 20, 2023

zhencliu commented Jun 20, 2023

YongxueHong left a comment

Choose a reason for hiding this comment

nickzhq commented Jun 20, 2023 •

edited

Loading

qingwangrh commented Jun 20, 2023 •

edited

Loading