Fixup VMIPAddressMissingError #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes vm failed to get ip because address cache is NULL, so need to update address cache before getting ip. Signed-off-by: cliping <[email protected]>
|
Before: After: |
chunfuwen
reviewed
Jul 11, 2023
| @@ -132,6 +132,10 @@ def ping_vm(self, vm, params, uri=None, ping_count=10, | |||
| func = exceptions.TestFail | |||
| uri_backup = vm.connect_uri | |||
| vm.connect_uri = uri | |||
| vm.cleanup_serial_console() | |||
There was a problem hiding this comment.
Do line 135 and 136 are necessary?
There was a problem hiding this comment.
They are necessary. The existing serial console may be connected to the source vm. So when we ping vm on dest, we need to clean the console first. Then we create a new serial console for vm on dest.
chloerh
approved these changes
Jul 27, 2023
bssrikanth
pushed a commit
to bssrikanth/avocado-vt
that referenced
this pull request
Nov 14, 2023
avocado-framework#3714 fixed in upstream. Signed-off-by: Dheeraj Kumar Srivastava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes vm failed to get ip because address cache is NULL, so
need to update address cache before getting ip.