[VT] Support vdpa device

[nickzhq]

No description provided.

[nickzhq]

The params added in boot.cfg: images += " image2" image_snapshot_image2 = no storage_type_image2 = "vhost-vdpa" image_name_image2 = blk0 image_format_image2 = raw remove_image_image2 = no force_create_image_image2 = no create_image_image2 = no check_image_image2 = no image_aio_image2 = native

The Kar command line used: python3 /home/kar/ConfigTest.py --testcase=boot --guestname=RHEL.9.0.0 --clone=no --customsparams="vm_mem_limit = 12G\nimage_aio=threads"

The qemu command line in log: [stdlog] -blockdev '{"node-name": "virtio-blk-vhost-vdpa_image2", "driver": "virtio-blk-vhost-vdpa", "auto-read-only": true, "discard": "unmap", "path": "/dev/vhost-vdpa-0", "cache": {"direct": true, "no-flush": false}}' [stdlog] -blockdev '{"node-name": "drive_image2", "driver": "raw", "read-only": false, "cache": {"direct": true, "no-flush": false}, "file": "virtio-blk-vhost-vdpa_image2"}' [stdlog] -device '{"driver": "scsi-hd", "id": "image2", "drive": "drive_image2", "write-cache": "on"}' \

cc @YongxueHong @zhencliu @qingwangrh @luckyh

Here's a kind reminder:
skip_image_processing = yes should be in the .cfg file. Otherwise, the case will be failed by "creating the qemu image" issue

CC @zhencliu , @YongxueHong @luckyh , @qingwangrh

[zhencliu]

skip_image_processing

The params added in boot.cfg: images += " image2" image_snapshot_image2 = no storage_type_image2 = "vhost-vdpa" image_name_image2 = blk0 image_format_image2 = raw remove_image_image2 = no force_create_image_image2 = no create_image_image2 = no check_image_image2 = no image_aio_image2 = native
The Kar command line used: python3 /home/kar/ConfigTest.py --testcase=boot --guestname=RHEL.9.0.0 --clone=no --customsparams="vm_mem_limit = 12G\nimage_aio=threads"
The qemu command line in log: [stdlog] -blockdev '{"node-name": "virtio-blk-vhost-vdpa_image2", "driver": "virtio-blk-vhost-vdpa", "auto-read-only": true, "discard": "unmap", "path": "/dev/vhost-vdpa-0", "cache": {"direct": true, "no-flush": false}}' [stdlog] -blockdev '{"node-name": "drive_image2", "driver": "raw", "read-only": false, "cache": {"direct": true, "no-flush": false}, "file": "virtio-blk-vhost-vdpa_image2"}' [stdlog] -device '{"driver": "scsi-hd", "id": "image2", "drive": "drive_image2", "write-cache": "on"}'
cc @YongxueHong @zhencliu @qingwangrh @luckyh

Here's a kind reminder: skip_image_processing = yes **should be in the .cfg file.

I am afraid we cannot set it for it is a 'global' param, if it's set, all images will be skipped @nickzhq

Otherwise, the case will be failed by "creating the qemu image" issue**

CC @zhencliu , @YongxueHong @luckyh , @qingwangrh

[qingwangrh]

LGTM

[YongxueHong]

The params added in boot.cfg: images += " image2" image_snapshot_image2 = no storage_type_image2 = "vhost-vdpa" image_name_image2 = blk0 image_format_image2 = raw remove_image_image2 = no force_create_image_image2 = no create_image_image2 = no check_image_image2 = no image_aio_image2 = native
The Kar command line used: python3 /home/kar/ConfigTest.py --testcase=boot --guestname=RHEL.9.0.0 --clone=no --customsparams="vm_mem_limit = 12G\nimage_aio=threads"
The qemu command line in log: [stdlog] -blockdev '{"node-name": "virtio-blk-vhost-vdpa_image2", "driver": "virtio-blk-vhost-vdpa", "auto-read-only": true, "discard": "unmap", "path": "/dev/vhost-vdpa-0", "cache": {"direct": true, "no-flush": false}}' [stdlog] -blockdev '{"node-name": "drive_image2", "driver": "raw", "read-only": false, "cache": {"direct": true, "no-flush": false}, "file": "virtio-blk-vhost-vdpa_image2"}' [stdlog] -device '{"driver": "scsi-hd", "id": "image2", "drive": "drive_image2", "write-cache": "on"}'
cc @YongxueHong @zhencliu @qingwangrh @luckyh

Here's a kind reminder: skip_image_processing = yes should be in the .cfg file. Otherwise, the case will be failed by "creating the qemu image" issue

We set the force_create_image_image2 = no, but why does it still create the image? Hi @nickzhq could you provide the related code of failed creating the qemu image? Thanks.
And I also have the same concern as @zhencliu mentioned. Could you run a test with multiple data images, both vdpa-blk and local file images? I guess that it will not process the local file images.
Thanks.

CC @zhencliu , @YongxueHong @luckyh , @qingwangrh

[nickzhq]

Hello @YongxueHong @zhencliu @qingwangrh @luckyh ,
Please take a view, here's a new change at env_process.py:
_call_check_image_func() and _call_image_func() both add a little codes.

After this updating, the param skip_image_processing is NOT needed.

@qingwangrh Could you run a testcase using the newest patch and put the result at the comment? My machine is NOT able to run.

Thanks!

[qingwangrh]

Hello @YongxueHong @zhencliu @qingwangrh @luckyh , Please take a view, here's a new change at env_process.py: _call_check_image_func() and _call_image_func() both add a little codes.

After this updating, the param skip_image_processing is NOT needed.

@qingwangrh Could you run a testcase using the newest patch and put the result at the comment? My machine is NOT able to run.

Thanks!

failed test

[nickzhq]

Hello @YongxueHong @zhencliu @qingwangrh @luckyh , Please take a view, here's a new change at env_process.py: _call_check_image_func() and _call_image_func() both add a little codes.

After this updating, the param skip_image_processing is NOT needed.

@qingwangrh Could you run a testcase using the newest patch and put the result at the comment? My machine is NOT able to run.

Thanks!

(1/1) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.hello_world.q35: STARTED
(1/1) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.hello_world.q35: PASS (43.55 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Hello @YongxueHong @zhencliu @qingwangrh @luckyh ,
Please take a view.
After this updating, the param skip_image_processing is NOT needed.

@qingwangrh Could you run a testcase using the newest patch and put the result at the comment? Please make a double check, please.

Thanks!

[zhencliu]

LGTM

[qingwangrh]

Pass test with skip_image_processing = no

LGTM

[nickzhq]

Pass test with skip_image_processing = no

LGTM

skip_image_processing = no is NOT necessary.

[nickzhq]

Hello @YongxueHong @zhencliu @luckyh
Please take a view, thanks.

Hello @qingwangrh ,
can you do the hello_world test again? And add the following params into hello_world.cfg , thanks in advance:
images += " stg1 stg2"
image_snapshot_stg1 = no
image_snapshot_stg2 = no
storage_type_stg1 = "vhost-vdpa"
storage_type_stg2 = "vhost-vdpa"
image_name_stg1 = blk0
image_name_stg2 = blk1
image_format_stg1 = raw
remove_image_stg1 = no
force_create_image_stg1 = no
create_image_stg1 = no
check_image_stg1 = no
image_format_stg2 = raw
remove_image_stg2 = no
force_create_image_stg2 = no
create_image_stg2 = no
check_image_stg2 = no
img_check_failed_stg1 = no
img_check_failed_stg2 = no
backup_image_after_testing_passed_stg1 = no
backup_image_after_testing_passed_stg2 = no

[qingwangrh]

Pass test with the following configuration or without.

Those configurations look a little redundant.
It is better and more transparent for the user.

img_check_failed_stg1 = no
img_check_failed_stg2 = no
backup_image_after_testing_passed_stg1 = no
backup_image_after_testing_passed_stg2 = no

[YongxueHong]

LGTM

[nickzhq]

Pass test with the following configuration or without.

Those configurations look a little redundant. It is better and more transparent for the user.

img_check_failed_stg1 = no img_check_failed_stg2 = no backup_image_after_testing_passed_stg1 = no backup_image_after_testing_passed_stg2 = no

Thanks to @qingwangrh .
Based on the this patch, the following params is NOT necessary:
img_check_failed_stg1 = no
img_check_failed_stg2 = no
backup_image_after_testing_passed_stg1 = no
backup_image_after_testing_passed_stg2 = no

cc @YongxueHong @zhencliu @luckyh

In conclusion, the pretty params should be as following:
images += " stg1 stg2"
image_snapshot_stg1 = no
image_snapshot_stg2 = no
storage_type_stg1 = "vhost-vdpa"
storage_type_stg2 = "vhost-vdpa"
image_name_stg1 = blk0
image_name_stg2 = blk1
image_format_stg1 = raw
remove_image_stg1 = no
force_create_image_stg1 = no
create_image_stg1 = no
check_image_stg1 = no
image_format_stg2 = raw
remove_image_stg2 = no
force_create_image_stg2 = no
create_image_stg2 = no
check_image_stg2 = no

[YongxueHong]

Thanks all @qingwangrh @nickzhq @zhencliu @luckyh
Let's merge it.