Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block_disk.py: Add a new utility for the block #3736

Merged
merged 1 commit into from
Sep 27, 2023
Merged

block_disk.py: Add a new utility for the block #3736

merged 1 commit into from
Sep 27, 2023

Conversation

nickzhq
Copy link
Contributor

@nickzhq nickzhq commented Aug 9, 2023

Here's a new block module including the functions
about the block.

@nickzhq nickzhq marked this pull request as draft August 9, 2023 03:07
@nickzhq nickzhq force-pushed the disk_module branch 2 times, most recently from 3873bbe to ed911a0 Compare August 10, 2023 06:15
@nickzhq nickzhq marked this pull request as ready for review August 28, 2023 08:44
@nickzhq
Copy link
Contributor Author

nickzhq commented Aug 28, 2023

@zhencliu @YongxueHong @luckyh Please take a review, thanks!

luckyh
luckyh reviewed Aug 29, 2023
View reviewed changes
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
@nickzhq nickzhq force-pushed the disk_module branch 2 times, most recently from db67950 to 8cc79ae Compare August 29, 2023 09:18
@nickzhq
Copy link
Contributor Author

nickzhq commented Aug 29, 2023

@zhencliu @YongxueHong @luckyh Please take a review, thanks!

@nickzhq
Copy link
Contributor Author

nickzhq commented Sep 13, 2023

@zhencliu @YongxueHong @luckyh Please take a review, thanks!

YongxueHong
YongxueHong reviewed Sep 20, 2023
View reviewed changes
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
YongxueHong
YongxueHong reviewed Sep 21, 2023
View reviewed changes
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
virttest/vt_utils/block_disk.py Outdated Show resolved Hide resolved
@nickzhq
Copy link
Contributor Author

nickzhq commented Sep 25, 2023

@YongxueHong @zhencliu Please take a check, thanks!

@YongxueHong
Copy link
Contributor

Hi @nickzhq
Codes are okay for me.
Just the commit, could you split it into different commits for both?
Thanks.

@nickzhq
Copy link
Contributor Author

nickzhq commented Sep 25, 2023 •
edited
Loading

Hi @nickzhq Codes are okay for me. Just the commit, could you split it into different commits for both? Thanks.

Hi @YongxueHong , both the filesystem module and the block module are involved by other.
I prefer to put codes in one commit.
But, I should update the commit message to summarize everything.

@YongxueHong
Copy link
Contributor

Hi @nickzhq Codes are okay for me. Just the commit, could you split it into different commits for both? Thanks.

Hi @YongxueHong , both the filesystem module and the block module are involved by other. I prefer to put codes in one commit. But, I should update the commit message to summarize everything.

Hi @nickzhq
Okay, your solution looks good to me

@nickzhq
Copy link
Contributor Author

nickzhq commented Sep 25, 2023

Hi @nickzhq Codes are okay for me. Just the commit, could you split it into different commits for both? Thanks.

Hi @YongxueHong , both the filesystem module and the block module are involved by other. I prefer to put codes in one commit. But, I should update the commit message to summarize everything.

Hi @nickzhq Okay, your solution looks good to me

Done.
Thanks!

@nickzhq
Copy link
Contributor Author

nickzhq commented Sep 26, 2023

@zhencliu @YongxueHong Please take a review, thanks!

@nickzhq nickzhq force-pushed the disk_module branch 4 times, most recently from a875a59 to c2acd73 Compare September 27, 2023 05:14
@YongxueHong
Copy link
Contributor

LGTM.

@nickzhq
vt_utils/block.py: Add a new utility for the block module
404752a 
vt_utils/filesystem.py: Add a new utility for the filesystem module

The previous utils_disk.py has been refactored into block module
and filesystem module.
The block.py providers the related functions about the block module.
The filesystem.py providers the related functions about
the filesystem module.

Signed-off-by: Houqi (Nick) Zuo <[email protected]>
@YongxueHong YongxueHong merged commit 01c4cb5 into avocado-framework:master Sep 27, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YongxueHong YongxueHong YongxueHong approved these changes

@luckyh luckyh luckyh left review comments

@zhencliu zhencliu zhencliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickzhq @YongxueHong @luckyh @zhencliu