env_process: Destroy unrequested VMs via a Setuper #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @YongxueHong, Could you review this too please? Thanks a lot! |
YongxueHong
reviewed
Sep 2, 2024
virttest/test_setup/vms.py
Outdated
| LOG = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class DestroyUnrequestedVMs(Setuper): |
There was a problem hiding this comment.
Hi @bgartzi
I see your point. The name DestroyUnrequestedVMs does sound quite specific and focuses only on the destruction aspect, while the actual functionality seems to handle both destroying and keeping the VMs, depending on the situation.
So I think we may choose a suitable name for both aspects, such as UnrequestedVMsHandler, UnrequestedVMsManager, and so on.
Anyway, the naming depends on how you view the class's role. I'd like to hear your thoughts.
Thanks.
There was a problem hiding this comment.
Hi @YongxueHong,
Thanks for sharing. Now that you mention it, I agree with you.
Let me update it really quick.
Refactor the piece of code that destroyed the unrequested VMs (if asked so) into a setuper. Import that class into env_process and register it into the setup_manager. Signed-off-by: Beñat Gartzia Arruabarrena <[email protected]>
bgartzi
force-pushed
the
env_process_refactoring-kill_unrequested_vms
branch
from
6dc943d
to
0514790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another
env_processrefactoring patch. This time is targeted towards the piece of code destroying those vms that weren't requested by the current test configuration (and still exist in the environment).ID: 2438