Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix for intel-iommu param aw-bits #4003

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Minor fix for intel-iommu param aw-bits #4003

merged 1 commit into from
Sep 19, 2024

Conversation

huangyum
Copy link
Contributor

@huangyum huangyum commented Sep 19, 2024 •
edited
Loading

ID: 2887
Signed-off-by: Yumei Huang [email protected]

PaulYuuu
PaulYuuu reviewed Sep 19, 2024
View reviewed changes
virttest/qemu_vm.py Outdated
@@ -1906,7 +1906,7 @@ def __iothread_conflict_check(params):
"x-scalable-mode": params.get("iommu_x_scalable_mode"),
"dma-drain": params.get("iommu_dma_drain"),
"pt": params.get("iommu_pt"),
"aw-bits": params.get("iommu_aw_bits"),
"aw-bits": params.get_numeric("iommu_aw_bits", 39),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If aw-bits expect int value, I think need to handle aw-bits in

avocado-vt/virttest/qemu_devices/qdevices.py

Lines 1243 to 1286 in 71b094f

# physical_block_size from device ("driver": "scsi-hd")
# logical_block_size from device ("driver": "scsi-hd")
# bootindex from device ("driver": "scsi-hd")
# max_sectors from device ("driver": "virtio-scsi-pci")
# num_queues from device ("driver": "virtio-scsi-pci")
# virtqueue_size from device ("driver": "virtio-scsi-pci")
# period, max-bytes from device ("driver": "virtio-rng-pci")
# max-write-zeroes-sectors, queue-size, max-discard-sectors,
# num-queues from device ("driver": "virtio-blk-pci")
# host_mtu, speed, vectors from
# device ( "driver": "virtio-net-pci" )
# node from device ("driver": "pc-dimm")
# events from device("driver": "pvpanic")
# min_io_size, opt_io_size from device ( "driver": "usb-storage" )
# discard_granularity from device ("driver": "scsi-hd") and
# ("driver": "virtio-blk-pci")
# guest-stats-polling-interval from
# device ("driver": "virtio-balloon-ccw")
# acpi-index from device("driver": "virtio-net-pci")
elif key in (
"physical_block_size",
"logical_block_size",
"bootindex",
"max_sectors",
"num_queues",
"virtqueue_size",
"discard_granularity",
"period",
"max-bytes",
"max-write-zeroes-sectors",
"queue-size",
"max-discard-sectors",
"num-queues",
"host_mtu",
"speed",
"vectors",
"node",
"events",
"min_io_size",
"opt_io_size",
"guest-stats-polling-interval",
"acpi-index",
):
command_dict[key] = int(val)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated accordingly.

@PaulYuuu
Copy link
Contributor

Cc @luckyh

@luckyh luckyh merged commit 5d272aa into avocado-framework:master Sep 19, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulYuuu PaulYuuu PaulYuuu approved these changes

@luckyh luckyh luckyh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangyum @PaulYuuu @luckyh