Enable IOMMUFD for VM device passthrough #4004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Farrah Chen <[email protected]> Signed-off-by: Xudong Hao <[email protected]>
PaulYuuu
reviewed
Sep 25, 2024
|
|
||
| def iommufd_object_define_by_params(self, obj_id): | ||
| """ | ||
| Create iommufd object device by params |
There was a problem hiding this comment.
Before creating an iommufd device, it is better to check that /dev/iommu exists.
| @@ -4031,9 +4031,25 @@ def hostdev_define_by_params(self, name, params, bus=None): | |||
| "failover_pair_id": params.get("vm_hostdev_failover_pair_id"), | |||
| } | |||
| ) | |||
| # Use hard code 'iommufd0' here, multiple devices use the same iommufd | |||
There was a problem hiding this comment.
As you mentioned here, multiple devices can use the same one. How about checking the iommufd as an ID? If the iommufd device exists with the same ID, reuse it; if not, create a new one, cause we should also support using different iommufd devices, what do you think?
| @@ -4031,9 +4031,25 @@ def hostdev_define_by_params(self, name, params, bus=None): | |||
| "failover_pair_id": params.get("vm_hostdev_failover_pair_id"), | |||
| } | |||
| ) | |||
| # Use hard code 'iommufd0' here, multiple devices use the same iommufd | |||
| if params.get("iommufd") == "yes": | |||
There was a problem hiding this comment.
In this code block, all parameters use vm_hostdev prefix, I would suggest align with this.
| @@ -4031,9 +4031,25 @@ def hostdev_define_by_params(self, name, params, bus=None): | |||
| "failover_pair_id": params.get("vm_hostdev_failover_pair_id"), | |||
| } | |||
| ) | |||
| # Use hard code 'iommufd0' here, multiple devices use the same iommufd | |||
| if params.get("iommufd") == "yes": | |||
| dev_params["iommufd"] = "iommufd0" | |||
There was a problem hiding this comment.
Currently, the iommufd is only used for VFIO devices, so I have an idea here,
devs = []
...
...
fd_id = params.get("vm_hostdev_iommufd")
if fd_id and not self.get_by_qid(fd_id):
iommufd = iommufd_object_define_by_params()
dev_params["iommufd"] = fd_id
devs.append(iommufd)
...
...
dev = qdevices.QDevice(driver, dev_params, parent_bus=dev_bus)
devs.append(dev)
return devsIf you have any concern, please don't hesitate to raise them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iommufd-backed VFIO, for example:
-object iommufd,id=iommufd0
-device vfio-pci,host=01:00.0,iommufd=iommufd0
Multiple pcie device can use the same iommufd.