Remove runners own timeouts. #5394
Comments
Closed
richtja
moved this from Long Term (Next Q) Backlog
to Short Term (Current Q) Backlog
in Default project
richtja
added a commit
to richtja/avocado
that referenced
this issue
Jul 14, 2023
This will remove unsystematic timeout inside avocado-instrumented runner. This timeout has been set to 24 hours and users haven't had a way how to change it. Because we solved problems with `task.timeout.running` in avocado-framework#5383 and `job-timeout` in avocado-framework#5295 this default timeout is not needed anymore. After this change, the users will have more power over timeouts and will be able to run instrumented tests longer than 24 hours. Reference: avocado-framework#5394 Signed-off-by: Jan Richter <[email protected]>
richtja
moved this from Short Term (Current Q) Backlog
to In progress
in Default project
richtja
added a commit
to richtja/avocado
that referenced
this issue
Jul 17, 2023
This will remove unsystematic timeout inside avocado-instrumented runner. This timeout has been set to 24 hours and users haven't had a way how to change it. Because we solved problems with `task.timeout.running` in avocado-framework#5383 and `job-timeout` in avocado-framework#5295 this default timeout is not needed anymore. After this change, the users will have more power over timeouts and will be able to run instrumented tests longer than 24 hours. Reference: avocado-framework#5394 Signed-off-by: Jan Richter <[email protected]>
richtja
added a commit
to richtja/avocado
that referenced
this issue
Aug 28, 2023
This will remove unsystematic timeout inside avocado-instrumented runner. This timeout has been set to 24 hours and users haven't had a way how to change it. Because we solved problems with `task.timeout.running` in avocado-framework#5383 and `job-timeout` in avocado-framework#5295 this default timeout is not needed anymore. After this change, the users will have more power over timeouts and will be able to run instrumented tests longer than 24 hours. Reference: avocado-framework#5394 Signed-off-by: Jan Richter <[email protected]>
github-project-automation
bot
moved this from In progress
to Done 103
in Default project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The runners shouldn't be dealing with timeouts by themself, but the timeout should be managed by avocado itself. Avocado has
task.timeout.runningand--job-timeout, those timeouts should be enough and there is no need for runner specific timeout.Right now, the avocado-instrumented runner has its own timeout defined here which is not connected with avocado timeouts and users can't manage it. This creates problems discussed in #5369. This timeout is not necessary and timeout should be managed by avocado.
Describe the solution you'd like
When the #5383 and #5295 will be solved, we have to ensure that there are no runner specific timeouts like the avocado-instrumented. Because the task timeout and job timeout should be enough for terminating runners.
Additional information
This is connected with timeout issues #5383 and #5295.
The text was updated successfully, but these errors were encountered: