Avocado-instrumented default timeout removal #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
richtja
force-pushed
the
default_timeout_fix
branch
from
1ba8b98
to
fe773aa
Compare
Sure thing, I will update that. Thanks for your review. |
This will remove unsystematic timeout inside avocado-instrumented runner. This timeout has been set to 24 hours and users haven't had a way how to change it. Because we solved problems with `task.timeout.running` in avocado-framework#5383 and `job-timeout` in avocado-framework#5295 this default timeout is not needed anymore. After this change, the users will have more power over timeouts and will be able to run instrumented tests longer than 24 hours. Reference: avocado-framework#5394 Signed-off-by: Jan Richter <[email protected]>
richtja
force-pushed
the
default_timeout_fix
branch
from
fe773aa
to
35a1e2d
Compare
|
Hi @clebergnu I added the exit code check. Please take a look. |
|
/packit copr-build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove unsystematic timeout inside avocado-instrumented runner. This timeout has been set to 24 hours and users haven't had a way how to change it. Because we solved problems with
task.timeout.runningin #5383 andjob-timeoutin #5295 this default timeout is not needed anymore. After this change, the users will have more power over timeouts and will be able to run instrumented tests longer than 24 hours.Reference: #5394