Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avocado-instrumented: Simplify implementation of status messages #5709

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

dgibson
Copy link
Contributor

@dgibson dgibson commented Jun 22, 2023

avocado-instrumented tests send periodic "runnning" messages if no other events are occurring. The implementation of this is quite convoluted, involving two variables with very long, but nonetheless cryptic names.

Replace this with a simplified implementation, using a single variable to indicate when the next running message should be sent

avocado-instrumented tests send periodic "runnning" messages if no other
events are occurring.  The implementation of this is quite convoluted,
involving two variables with very long, but nonetheless cryptic names.

Replace this with a simplified implementation, using a single variable to
indicate when the next running message should be sent

Signed-off-by: David Gibson <[email protected]>
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dgibson, thank you for this, it LGTM. We are now in feature freeze state and preparing release 102. Therefore, this will be merged after the release.

@richtja richtja merged commit 7c10487 into avocado-framework:master Jun 26, 2023
@dgibson dgibson deleted the simplify-timeout branch July 3, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants