The rstrip() method removes slashes at the end of the path string instead of slicing #5724
Conversation
geyaning
force-pushed
the
master
branch
7 times, most recently
from
ea97db8
to
d0fc507
Compare
There was a problem hiding this comment.
Hi @geyaning, thank you for your contribution. I have just a few comments to make tests happy.
PS: I also noticed that you use your master branch for creating PRs. It is a good practice to create a working branch and not use master for development. It will make you live easier and you can work on more than one branches at a time. For more info about PR process, you can read this article.
avocado/utils/cloudinit.py
Outdated
| path = self.path[1:] | ||
| if path[-1] == "/": | ||
| path = path[:-1] | ||
| path = self.path.rstrip('/') |
There was a problem hiding this comment.
The previous code also removed the first character, therefore your changes change the behavior and tests are failing. What about to use self.path[1:].rstrip("/") ?
There was a problem hiding this comment.
Thank you very much for your prompt, the access control is OK now, you can check what other requirements, please tell me, if not, please merge
…tead of slicing Signed-off-by: geyaning <[email protected]>
The rstrip() method removes slashes at the end of the path string instead of slicing
Move the assignment to self.server.instance_phoned_back inside the conditional statement to avoid unnecessary judgment.