avocado/core/loader.py: support Python 3.12 by using importlib #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The imp module is no longer available on Python 3.12. Besides enabling usage under Python 3.12, also works as a backport for a test file location import fix. This also enables RPM builds under Fedora 39. Reference: avocado-framework#5686 Reference: https://bugzilla.redhat.com/show_bug.cgi?id=2220126 Signed-off-by: Cleber Rosa <[email protected]>
urllib3 is a dependency of requests, which is a dependency of resultsdb_api. Because there's no pinning of version elsewhere, a version that is incompatible with Python 3.6 can end being installed. Signed-off-by: Cleber Rosa <[email protected]>
There are API changes in versions 6.0 and later that (at the very least) trigger lint errors. Let's be safe and use known compatible versions. Signed-off-by: Cleber Rosa <[email protected]>
richtja
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Hi @clebergnu, it is LGTM, but there are still some pending jobs left.
It seems there are no workers available using the old macOS version. Let's bump to the one being used on the latest Avocado along with the Python version it uses. Signed-off-by: Cleber Rosa <[email protected]>
CI is now happy! Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The imp module is no longer available on Python 3.12. Besides enabling usage under Python 3.12, also works as a backport for a test file location import fix.
This also enables RPM builds under Fedora 39.
Reference: #5686
Reference: https://bugzilla.redhat.com/show_bug.cgi?id=2220126