Dependencies weren't fulfilled fix #5731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add kwargs variable to the Finish message utility, which will make the utility much the utility more variable for different types of use cases. Signed-off-by: Jan Richter <[email protected]>
This will remove the hard coded messages dicts from `Worker` and leave the generation of the messages to avocado.core.utils.messages. This change increases the readability and maintainability of `Worker` messages. Signed-off-by: Jan Richter <[email protected]>
This commit adds information about skipping test due to the missing dependencies. Before this commit: ``` avocado run /tmp/test.py JOB ID : b17da893039e9d2deb33445a277ed2da40739a0d JOB LOG : /home/janrichter/avocado/job-results/job-2023-04-20T13.55-b17da89/job.log RESULTS : PASS 0 | ERROR 0 | FAIL 0 | SKIP 1 | WARN 0 | INTERRUPT 0 | CANCEL 0 JOB HTML : /home/janrichter/avocado/job-results/job-2023-04-20T13.55-b17da89/results.html JOB TIME : 2.20 s ``` After this commit: ``` avocado run /tmp/test.py JOB ID : b17da893039e9d2deb33445a277ed2da40739a0d JOB LOG : /home/janrichter/avocado/job-results/job-2023-04-20T13.55-b17da89/job.log (1/1) /tmp/test.py:PassTest.test: STARTED (1/1) /tmp/test.py:PassTest.test: SKIP: Dependecies wasn't fulfilled. RESULTS : PASS 0 | ERROR 0 | FAIL 0 | SKIP 1 | WARN 0 | INTERRUPT 0 | CANCEL 0 JOB HTML : /home/janrichter/avocado/job-results/job-2023-04-20T13.55-b17da89/results.html JOB TIME : 2.20 s ``` Reference: avocado-framework#5657 Signed-off-by: Jan Richter <[email protected]>
clebergnu
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
LGTM, and works great:
avocado run examples/tests/dependency_ansible.py
JOB ID : 22a2370074ded7ad61e47ec7c5565ceb2449a6ef
JOB LOG : /home/cleber/avocado/job-results/job-2023-07-17T18.19-22a2370/job.log
(2/2) examples/tests/dependency_ansible.py:UserByAnsible.test: STARTED
(2/2) examples/tests/dependency_ansible.py:UserByAnsible.test: SKIP: Dependency was not fulfilled.
(1/2) examples/tests/dependency_ansible.py:FileByAnsible.test: STARTED
(1/2) examples/tests/dependency_ansible.py:FileByAnsible.test: PASS (0.01 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 1 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /home/cleber/avocado/job-results/job-2023-07-17T18.19-22a2370/results.html
JOB TIME : 4.72 s
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information about skipping test due to the missing
dependencies.
Before this PR:
After this PR:
Reference: #5657
Signed-off-by: Jan Richter [email protected]