Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Avocado jobs command #5762

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Improve Avocado jobs command #5762

merged 2 commits into from
Oct 16, 2023

Conversation

v1siuol
Copy link
Contributor

@v1siuol v1siuol commented Sep 8, 2023

Fix #5761

@mr-avocado
Copy link

mr-avocado bot commented Sep 8, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

richtja
richtja requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @v1siuol thank you for your contribution, I very appreciate it. Overall, the changes LGTM. I have just some comments to style, so our checks will be ok.

Please add your sign into your commit based on our Commit style guide.

Run black . command in avocado root dir, that will fix all your style issues based on our style requirements.

If you need any help with those changes, don't hesitate to ask. We will help you.

.gitignore Outdated Show resolved Hide resolved
@richtja richtja added the bug label Sep 11, 2023
@v1siuol v1siuol changed the title Sort jobs list results by mtime Improve Avocado jobs command Sep 12, 2023
v1siuol
v1siuol commented Sep 12, 2023
View reviewed changes
avocado/plugins/jobs.py Outdated Show resolved Hide resolved
richtja added a commit to richtja/avocado that referenced this pull request Sep 14, 2023
@richtja
Actual time in json results
9ce46ab 
We use monotonic time format in json result for start and end tests.
Even this is more accurate format, sometimes it is difficult to work
with it. Therefore, this adds also actual time to the results, which is
the time in seconds, based on `time.time()`.

Reference: avocado-framework#5762
Signed-off-by: Jan Richter <[email protected]>
@richtja richtja mentioned this pull request Sep 14, 2023
Merged
richtja
richtja approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @v1siuol, thank you for your update, it LGTM.

@richtja richtja merged commit ea47fd8 into avocado-framework:master Oct 16, 2023
58 checks passed
@v1siuol v1siuol deleted the fix_jobs branch October 16, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtja richtja richtja approved these changes

Assignees

@v1siuol v1siuol

Labels
bug
Projects
Default project
Archived in project
Milestone
#103 (LTS release - Sound of Freedom)
Development

Successfully merging this pull request may close these issues.

Improve Avocado jobs command
2 participants
@v1siuol @richtja