Adding check if the test interface tested is a bonding slave #5782
Conversation
|
Dear contributor,
As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality, |
|
Hello @vaishnavibhat, could you please correct the indentation to ensure that the CI will pass? We will proceed with the review once the CI successfully passes. Thank you. |
The patch is to test if the interface is a slave interface or a regular one. when mac address is passed as test param, return only for a regular interface or a bond master interface. Signed-off-by: Vaishnavi Bhat <[email protected]>
vaishnavibhat
force-pushed
the
bond_slave
branch
from
6d2ef48
to
4a109a3
Compare
There was a problem hiding this comment.
Hi @vaishnavibhat, sorry for the late reply. The style checks are still complaining, please have a look. Thank you.
| return True | ||
| except (NWException, IndexError): | ||
| raise NWException("Could not get interface detail.") | ||
| return False |
There was a problem hiding this comment.
IMO, this return shouldn't be part of the except clause, am I right.
|
Hi @vaishnavibhat gentle ping here. |
|
Hi @vaishnavibhat, since this has been inactive for some time, I am closing this. But feel free to reopen it if you want to continue in this. |
The patch is to test if the interface is a slave interface or a regular one. when mac address is passed as test param, return only for a regular interface or a bond master interface.