Podman Improvements #5783
Podman Improvements #5783
Conversation
|
Dear contributor,
As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality, |
clebergnu
force-pushed
the
podman_improvs
branch
from
021660d
to
5ba4cb4
Compare
clebergnu
force-pushed
the
podman_improvs
branch
2 times, most recently
from
404ab40
to
11e237e
Compare
There was a problem hiding this comment.
Hi @clebergnu, thank you for this update. Overall the changes LGTM, there is just one small issue with _podman variable, I think it should be part of different commit. Can you please update it? Thank you.
avocado/plugins/spawners/podman.py
Outdated
| @@ -142,6 +142,17 @@ def podman_version(self): | |||
| if self._podman_version == (None, None, None): | |||
| self._podman_version = self._get_podman_version() | |||
| return self._podman_version | |||
| self._podman = None | |||
There was a problem hiding this comment.
This will never be used, I think it is a mistake.
avocado/plugins/spawners/podman.py
Outdated
| @@ -142,7 +143,6 @@ def podman_version(self): | |||
| if self._podman_version == (None, None, None): | |||
| self._podman_version = self._get_podman_version() | |||
| return self._podman_version | |||
| self._podman = None | |||
There was a problem hiding this comment.
I can see that you removed it here. Can you please add this to the proper commit? Thank you.
There's significant change in how to get some information from containers under Podman version 3.x.x and 4.x.x. This adds a property to the spawner that will reflect the Podman version being used, and logs it on initialization. Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
podman_improvs
branch
from
11e237e
to
3bf97ba
Compare
Good catch! It was a bad rebase on my side. I've pushed an updated version. |
Signed-off-by: Cleber Rosa <[email protected]>
This updates the method that is used to detect if the container is running, adding a (by default, one time) timeout between the "created" and "running" state. Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
podman_improvs
branch
from
3bf97ba
to
b6fbc16
Compare
This is a collection of small improvements and one fix to a race condition, where the state of the container (and thus the task) would not take into account the transition from "created" to "running".