Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Amazon Linux distro description #5835

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Update Amazon Linux distro description #5835

merged 1 commit into from
Dec 21, 2023

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Dec 15, 2023

Update Amazon Linux distro description

Reference: #5668

@richtja richtja added the bug label Dec 15, 2023
@richtja richtja self-assigned this Dec 15, 2023
@richtja richtja linked an issue Dec 15, 2023 that may be closed by this pull request
Distro detection: AmazonLinux Stream broken #5668
Closed
@mr-avocado
Copy link

mr-avocado bot commented Dec 15, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

clebergnu
clebergnu requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@clebergnu clebergnu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distro detection is expected to return:

Detected distribution: amzn (x86_64) version 2023 release 0

But it's returning:

Detected distribution: amzn (x86_64) version 2023 release None

@richtja
Copy link
Contributor Author

richtja commented Dec 21, 2023

The distro detection is expected to return:

Detected distribution: amzn (x86_64) version 2023 release 0

But it's returning:

Detected distribution: amzn (x86_64) version 2023 release None

Thank you for catching that, I will fix it

clebergnu
clebergnu approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clebergnu clebergnu merged commit 6ac3336 into avocado-framework:master Dec 21, 2023
56 of 63 checks passed
@richtja richtja deleted the amzn_distro branch December 21, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clebergnu clebergnu clebergnu approved these changes

Assignees

@richtja richtja

Labels
bug
Projects
Default project
Archived in project
Milestone
#103 (LTS release - Sound of Freedom)
Development

Successfully merging this pull request may close these issues.

Distro detection: AmazonLinux Stream broken
2 participants
@richtja @clebergnu