Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a quick guide for setting up the remote spawner #5846

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Add a quick guide for setting up the remote spawner #5846

merged 1 commit into from
Jan 2, 2024

Conversation

clebergnu
Copy link
Contributor

This Documents some crucial steps for a new user of the remote spawner plugin.

Reference: #5838

@clebergnu clebergnu self-assigned this Dec 28, 2023
@mr-avocado
Copy link

mr-avocado bot commented Dec 28, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

@clebergnu clebergnu mentioned this pull request Dec 28, 2023
Closed
richtja
richtja requested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @clebergnu, thank you for this update. I have just one proposal about aexpect, what do you think?

optional_plugins/spawner_remote/README.rst Outdated Show resolved Hide resolved
pevogam
pevogam approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@pevogam pevogam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @clebergnu, I have to confess I did not expect this extra step on your side but the documentation is both succinct and extensive and other than a few minor typos I say LGTM.

optional_plugins/spawner_remote/README.rst Outdated Show resolved Hide resolved
@clebergnu
Add a quick guide for setting up the remote spawner
87a9826 
This Documents some crucial steps for a new user of the remote spawner
plugin.

Reference: avocado-framework#5838
Signed-off-by: Cleber Rosa <[email protected]>
@clebergnu
Copy link
Contributor Author

updated with @richtja and @pevogam comments/requests.

richtja
richtja approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks for the update.

@richtja richtja merged commit b496a7c into avocado-framework:master Jan 2, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtja richtja richtja approved these changes

@pevogam pevogam pevogam approved these changes

Assignees

@clebergnu clebergnu

Labels
documentation
Projects
Default project
Archived in project
Milestone
#103 (LTS release - Sound of Freedom)
Development

Successfully merging this pull request may close these issues.
3 participants
@clebergnu @pevogam @richtja