Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure temporary file removal #5854

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Jan 15, 2024

The tmpfile.mktemp function for creating tmp files has been deprecated since 2.3 and has security issues. Let's remove it and use tmpdir instead.

Reference:
https://github.com/avocado-framework/avocado/security/code-scanning/278

@richtja richtja added this to the #104 - Codename TBD milestone Jan 15, 2024
@richtja richtja self-assigned this Jan 15, 2024
The tmpfile.mktemp function for creating tmp files has been depraceted
since 2.3 and has security issues. Lets remove it and use
tmpdir instead.

Reference:
https://github.com/avocado-framework/avocado/security/code-scanning/278
Signed-off-by: Jan Richter <[email protected]>
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clebergnu clebergnu merged commit ab0107f into avocado-framework:master Jan 16, 2024
63 checks passed
@richtja richtja deleted the tmpfile_fix branch March 26, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants