Backwards compatibility for kernel utils module #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix of kerne utils compatibility issue with setuptools=>70 which has been introduced in df6b1da. Reference: avocado-framework#5988 Signed-off-by: Jan Richter <[email protected]>
|
Hi @clebergnu and @harvey0100, gentle ping here. |
harvey0100
approved these changes
Aug 19, 2024
clebergnu
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
LGTM:
avocado]# pip install .
Processing /root/src/avocado
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: setuptools in /usr/lib/python3.12/site-packages (from avocado-framework==106.0) (69.0.3)
Building wheels for collected packages: avocado-framework
Building wheel for avocado-framework (pyproject.toml) ... done
Created wheel for avocado-framework: filename=avocado_framework-106.0-py3-none-any.whl size=449555 sha256=e3d3b8dd964f8f1154eb6aa25f103014bab6e496681e2030dbddfbb3fafe515a
Stored in directory: /tmp/pip-ephem-wheel-cache-r5d_tj57/wheels/fd/07/08/6c0eba8c6ebbb2d42c259865dd7cb0d04641f2914d999dbd02
Successfully built avocado-framework
Installing collected packages: avocado-framework
Attempting uninstall: avocado-framework
Found existing installation: avocado-framework 106.0
Uninstalling avocado-framework-106.0:
Successfully uninstalled avocado-framework-106.0
Successfully installed avocado-framework-106.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
[root@a09a6f522775 avocado]# python3 -c 'import avocado.utils.kernel'
[root@a09a6f522775 avocado]# git show
commit 58738b61a8bd6af542ff82a2ccccb49551c48c1b (HEAD -> packaging_import_fix, richtja/packaging_import_fix)
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix of kerne utils compatibility issue with setuptools=>70 which has been introduced in df6b1da.
Reference: #5988