Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvc_annotator: remove already being provisioned check #22

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

chaireze
Copy link
Collaborator

On multi node clusters it seems like an extra NodeStageVolume is needed in order for loadgens to mount correctly. Removing this is temporary as that shouldn't be needed.

Copy link
Collaborator

@silindbl-msft silindbl-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - can you file a follow up PBI to enable it?

@github-actions
Copy link

Pull Request Test Coverage Report for Build 5536582711

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 78.775%

Totals Coverage Status
Change from base Build 5533423621: 0.02%
Covered Lines: 2071
Relevant Lines: 2629

💛 - Coveralls

@chaireze chaireze merged commit 5982ae7 into staging Jul 12, 2023
13 checks passed
@chaireze chaireze deleted the echairez/dont-block-already-provisioned-calls branch July 12, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants