Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new volume states #25

Merged
merged 3 commits into from
Aug 10, 2023
Merged

new volume states #25

merged 3 commits into from
Aug 10, 2023

Conversation

chaireze
Copy link
Collaborator

We're changing the code in Hydra to accept pvcs with volume states: 'not created' and 'creating'

These changes reflect that. We need a new chart since these changes are not backwards compatible.

@chaireze chaireze force-pushed the echairez/create-volume-states branch from c75df7c to 94f7717 Compare August 10, 2023 17:13
@chaireze chaireze marked this pull request as ready for review August 10, 2023 17:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5824093204

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 78.571%

Files with Coverage Reduction New Missed Lines %
pkg/edgecache/cachevolume/pvc_annotator.go 5 89.66%
Totals Coverage Status
Change from base Build 5789122405: -0.2%
Covered Lines: 2079
Relevant Lines: 2646

💛 - Coveralls

@chaireze chaireze merged commit 0caf6fa into staging Aug 10, 2023
13 checks passed
@chaireze chaireze deleted the echairez/create-volume-states branch August 10, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants