Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure azure cloud config can be loaded from secret #35

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

mkandawires
Copy link
Collaborator

Manually pickup fixes from upstream:

  • ensures azure cloud config can be loaded from secret
  • fix goveralls

What type of PR is this?

What this PR does / why we need it:

  • ensures azure cloud config can be loaded from secret
  • fix goveralls
    Which issue(s) this PR fixes:
  • ensures azure cloud config can be loaded from secret
  • fix goveralls

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

Manually pickup fixes from upstream:
- ensures azure cloud config can be loaded from secret
- fix goveralls
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8193857544

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-16.1%) to 60.724%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/blob/azure.go 0 1 0.0%
Totals Coverage Status
Change from base Build 7561919467: -16.1%
Covered Lines: 2398
Relevant Lines: 3949

💛 - Coveralls

@mkandawires mkandawires merged commit 930a8bd into staging Mar 7, 2024
13 checks passed
@mkandawires mkandawires deleted the mkandawires/fix-load-config-from-secret branch March 7, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants