(maint) tidy build steps, fix permissions and add uninstall recipe #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit following the `make`/`make install` steps would fail due to the `pinata-build-sshd.sh` attempting to cd to `/usr/local/share/pinata-ssh-agent` directory before it had been created by `make install`. This commit builds the image in the workspace directory, removes the unused `ssh-build.sh` and tidies the Makefile accordingly.
Prior to this commit the mapped public key to authorized hosts would inherit the uid/gid from the OSX host, this commit sets the ownership back to root in the container before starting sshd.
This commit adds an uninstall recipe for the scripts installed to /usr/local/bin. ``` make uninstall ```
|
Thanks for the work on this @avsm, its unblocked me while waiting on docker/for-mac#483 to be resolved |
johnmccabe
changed the title
johnmccabe
changed the title
|
Works fine on Sierra. |
johnmccabe
changed the title
|
I've included this and more in https://github.com/uber-common/docker-ssh-agent-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up the build steps and sets the ownership of authorized_hosts to root:root, was inheriting the uid/gid of the user on the host OS. I've also added an uninstall recipe to the Makefile.
I've cherry picked in the fixes from the PRs raised by @netj.
This is currently working for me as expected on OSX 10.11.6 (I'll check with Sierra in the morning).