Skip to content
This repository was archived by the owner on Sep 23, 2025. It is now read-only.

Render null if width or height is 0 or falsy #64

Open
wants to merge 1 commit into
base: v1.3.0
Choose a base branch
from
Open

Render null if width or height is 0 or falsy #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ module.exports = function Dimensions ({
}
return (
<div className={className} style={containerStyle} ref='container'>
{(containerWidth || containerHeight) &&
{!(containerWidth || containerHeight) : null ?
Copy link

@tcoughlin3 tcoughlin3 Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is probably pending a maintainer. But just to note, it appears the ternary has the ? and : in the incorrect order.

<ComposedComponent
{...this.state}
{...this.props}
Expand Down