Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opik #1036

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Opik #1036

wants to merge 6 commits into from

Conversation

anmorgan24
Copy link

Thanks for taking the time to suggest an addition to awesome-selfhosted!

To ensure your Pull Request is dealt with swiftly, please check the following (check the boxes [x]):

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

@TheGiraffe3
Copy link
Contributor

It looks like you included the whole issue body, not just the text required. Could you remove everything outside of the ```yaml tag?

@Ki-er Ki-er added addition Adding new software to the list reviewers wanted Awaiting reviews labels Dec 24, 2024
Copy link
Collaborator

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated above

software/opik.yml Outdated Show resolved Hide resolved
software/opik.yml Outdated Show resolved Hide resolved
anmorgan24 and others added 2 commits December 24, 2024 15:31
@anmorgan24
Copy link
Author

Thank you so much for the super fast review and for suggesting the changes for me! I just accepted them all. Hopefully the PR should be all set now, but if you need me to update anything else, just let me know!

Copy link
Collaborator

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution.

This project has not had a release within 12 months which is required for all projects to be added to awesome-selfhosted. Due to this, I think that we should wait 4 months, similiar to new projects due to the lack of releases.

We also recommend maintaining a simple changelog that will help users in tracking software changes, particularly those that are breaking changes or require configuration modifications.

Other reviewers can weigh in.

software/opik.yml Outdated Show resolved Hide resolved
software/opik.yml Outdated Show resolved Hide resolved
@nodiscc nodiscc added feedback needed Awaiting feedback/changes by the submitter on hold Issue/PR should be revisited later labels Dec 28, 2024
@jverre
Copy link

jverre commented Dec 30, 2024

Hi @nodiscc @Ki-er
Following up on this for @anmorgan24

We have a bit of a mess on the Github repo that means that the timestamp for the releases are not actually the timestamps of the release but rather the creation time of another un-related release that was subsequently deleted.

We did actually do a release earlier this morning that has the correct timestamp in the Github release page, version 1.3.3 as can be seen here: https://github.com/comet-ml/opik/releases.

Here are also a few more places that showcase the fact that we try to do at least 1 release a week:

Hopefully this clarifies a few things, sorry for the Github releases mess 😅

@nodiscc nodiscc removed the on hold Issue/PR should be revisited later label Jan 1, 2025
@nodiscc nodiscc removed reviewers wanted Awaiting reviews feedback needed Awaiting feedback/changes by the submitter labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding new software to the list
Development

Successfully merging this pull request may close these issues.

5 participants